[Breaking changes] Rework combobox-nav APIs and use ARIA 1.2 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `install()` has been renamed to `start()` - `uninstall()` has been renamed `stop()` - Newly added `install()` sets require ARIA attributes - Newly added `uninstall()` removes ARIA attributes
dgraham
approved these changes
Apr 22, 2020
|
@muan This looks great! Happy to test when you'd like me to.
aria-haspopup is definitely problematic in a number of cases, mostly
because when you use values such as "dialog" on roles like buttons, many
screen readers will still treat it as "menu". But for combo boxes, the
screen reader should do the right thing, because specifying that a combo
box has a sub-menu doesn't really make any sense in the first place. So
the same problem doesn't occur.
TL;DR: use aria-haspopup on combo boxes :)
|
|
@jscholes Thanks! There are some more structural changes we want to make so I'm going to merge this first without cutting a release so avoid a giant PR. I'll ping you once those are reviewed, and definitely before we publish a new release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
install()has been renamed tostart(), for use when options shows upuninstall()has been renamedstop(), for use when options are removedinstall()sets required ARIA attributes, for initializationuninstall()removes ARIA attributes, for breakdown@jscholes This now adds an additional (required) call to set ARIA attributes; this was previously done inside of
<auto-complete>'s element connected callback. I have one remaining question: Spec says to setaria-haspopup, but we've previously gotten the feedback that support for the attribute is poor for non-menu values. Would you recommend that we leave that out still here? EDIT: looks like the spec says it's already implicitly set to listbox for elements with combobox role.