Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Quirks with dialog trigger "button"s #34

Closed
scottaohara opened this issue May 2, 2019 · 2 comments Β· Fixed by #35
Closed

Quirks with dialog trigger "button"s #34

scottaohara opened this issue May 2, 2019 · 2 comments Β· Fixed by #35

Comments

@scottaohara
Copy link

Per the manner in which the summary element is exposed to Safari's Webkit (announced as "summary" but no matching ARIA role) and Blink (announced as and reported as a "DisclosureTriangle"role) these "buttons" are not discoverable when navigating by form controls or button elements with VoiceOver on macOS or iOS.

Additionally, due to poor support for aria-haspopup="dialog" these elements will be exposed as popup buttons for "menus", which, depending on the screen reader will inform a user certain keys will become available to them, which is not true.

I would suggest that role=button is added to the summary elements when JavaScript is enabled to better ensure these elements which are visually presented as buttons are also discoverable as the buttons they are meant to be.

Additionally, I would suggest that aria-haspopup=dialog is removed until it receives better support.

@Adriani90
Copy link

As an NVDA user on Windows, I am not sure if this information is given to sighted people by a design patern. Does a sighted person use this information for understanding data structures or for a more efficient navigation? If web developers are implementing this aria has popup dialog on their websites, tools etc, at least for me as a screen reader user knowing what the button will open would be an important information. Especially on very complex sites like data bases (i.e. worldbank, EIU and so on).

@muan muan closed this as completed in #35 May 8, 2019
@muan
Copy link
Contributor

muan commented May 8, 2019

Thank you so much for reporting this! The fix is released as v3.0.3, and upgrades for github.com will soon follow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants