This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Remove aria-haspopup=dialog and add role=button #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aria-haspopup=dialog Using NVDA as an example: nvaccess/nvda#8235 - role=button While the default summary role (disclosure triangle) could be appropriate elsewhere, dialog's trigger element should be announced as a button.
koddsson
approved these changes
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Remove
aria-haspopup="dialog"from<summary>due to poor support creating negative user experience. For reference, here's an open issue on NVDA. We can revisit this down the line.Add
role="button"to<summary>. A dialog's trigger element should be announced as a button.