Support selecting menu item from <input> #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so menus can be navigated without leaving an input focus
koddsson
approved these changes
Oct 22, 2019
getCurrentFocus is always used in conjunction with these two other checks. This refactor would save us from having to write those checks at every call site.
This was referenced Oct 23, 2019
|
We're no longer pursuing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a menu contains a filtering input, navigating items will take user's focus away from the input. This creates quite an annoyance when quick filtering actions are performed.
This adds support for managing focus via
aria-activedescendantwhen an input is specified on the menu element, and said input is focused. Aside from settinginputattribute, the markup should also fulfill the following (not enforced by details-menu):aria-ownson<input>targeting the menu item containeridandroleon the menu item container sincerole=menushould not contain<input>idon each of the menu item (there is a dynamically generated ID, but in testing it seems AT might be slow in picking them up):focus, [aria-selected="true"]References:
:focus