Prevent keyboard events during text composition inside of details-menu #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: https://github.com/github/web-systems/issues/228.
Like #38 and #39 this aims to better support having text inputs inside of
<details-menu>
. This one can be merged independently.For background on this approach, refer to the research I've done when fixing github/combobox-nav#2. (
event.isComposing
is not supported in non-Chromium Edge)You can test this locally with an IME of your choosing and with this simple markup:
In the GIFs I was testing with bopomofo. You can do the same by following Apple's instruction.