Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent keyboard events during text composition inside of details-menu #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muan merged 3 commits into from
Nov 15, 2019
Merged

Prevent keyboard events during text composition inside of details-menu #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e020ae2
Prevent keyboard events during text composition inside of details-menu
muan Oct 23, 2019
24b7d3c
Merge branch 'master' into composition
muan Nov 15, 2019
2590a24
Prioritize ignoring keyscroke from nested details
muan Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ class DetailsMenuElement extends HTMLElement {
}

const subscriptions = [
fromEvent(details, 'compositionstart', e => trackComposition(this, e)),
fromEvent(details, 'compositionend', e => trackComposition(this, e)),
fromEvent(details, 'click', e => shouldCommit(details, this, e)),
fromEvent(details, 'change', e => shouldCommit(details, this, e)),
fromEvent(details, 'keydown', e => keydown(details, this, e)),
Expand All @@ -49,7 +51,7 @@ class DetailsMenuElement extends HTMLElement {
...focusOnOpen(details)
]

states.set(this, {subscriptions, loaded: false})
states.set(this, {subscriptions, loaded: false, isComposing: false})
}

disconnectedCallback() {
Expand Down Expand Up @@ -214,10 +216,12 @@ function commit(selected: Element, details: Element) {

function keydown(details: Element, menu: DetailsMenuElement, event: Event) {
if (!(event instanceof KeyboardEvent)) return
const isSummaryFocused = event.target instanceof Element && event.target.tagName === 'SUMMARY'

// Ignore key presses from nested details.
if (details.querySelector('details[open]')) return
const state = states.get(menu)
if (!state || state.isComposing) return

const isSummaryFocused = event.target instanceof Element && event.target.tagName === 'SUMMARY'

switch (event.key) {
case 'Escape':
Expand Down Expand Up @@ -318,6 +322,12 @@ function labelHTML(el: ?Element): ?string {
return contentsEl ? contentsEl.innerHTML : null
}

function trackComposition(menu, event: Event) {
const state = states.get(menu)
if (!state) return
state.isComposing = event.type === 'compositionstart'
}

export default DetailsMenuElement

if (!window.customElements.get('details-menu')) {
Expand Down