Merged
Conversation
Removes null and type checking on event targets we know to be correct.
Consolidates adding and removing listeners into a subscription pattern.
keithamus
approved these changes
Nov 11, 2019
Contributor
keithamus
left a comment
There was a problem hiding this comment.
LGTM 👍
I really like the clean nature of subscriptions with cleanup, and the implementation to convert (add|remove)EventListener into them is neat 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch expands the use of the event subscription pattern to handle removing all event listeners. There are enough listeners to warrant this now, and this would have prevented the copy/paste typo in #40 that should be calling
removeEventListener.In addition to listener cleanup, this binds listeners to the details and menu elements so they don't need to typecast or query the tree for them. The subscription pattern avoids tracking bound listener functions in the element's state so they may be deregistered later.