Thanks to visit codestin.com
Credit goes to github.com

fix: Remove resource group from module #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

npalm merged 1 commit into github-aws-runners:develop from jake-naughton:issue-2417

Oct 11, 2022

Contributor

jake-naughton commented Oct 10, 2022 •

edited

Loading

Fix for bug #2417 to remove resource group from module since we are no longer setting a predefined tag to all resources.

Tests all passed locally.

Pre commit checks updated terraform docs to include missing documentation from a recently merged pull request for S3. Happy to remove these commits and leave them for a separate pull request.


          fix: remove resource group from module

ab1ca1d

- Since we are no longer setting a predefined tag to all resources.

jake-naughton mentioned this pull request

Resource Groups are no longer working #2417

Closed

npalm self-requested a review

October 11, 2022 09:53

npalm approved these changes

View reviewed changes

Member

npalm left a comment

Thanks looks good, will run a quick test later

npalm changed the title ~~fix: remove resource group from module~~ fix: Remove resource group from module

Member

npalm commented Oct 11, 2022

Thx for you help, all good!

npalm merged commit 2628352 into github-aws-runners:develop

forest-releaser bot pushed a commit that referenced this pull request


          chore(release): 1.12.0 [skip ci]

ffc2e38

## [1.12.0](philips-labs/terraform-aws-github-runner@v1.11.0...v1.12.0) (2022-10-12)

### Features

* Added the AMI to machine setup info to runner workflows. ([#2451](https://github.com/philips-labs/terraform-aws-github-runner/issues/2451)) ([e197cbd](philips-labs/terraform-aws-github-runner@e197cbd))
* **images:** add ami for windows core 2022 ([#2390](https://github.com/philips-labs/terraform-aws-github-runner/issues/2390)) ([97707c2](philips-labs/terraform-aws-github-runner@97707c2))
* Log workflow id in webhook ([#2511](https://github.com/philips-labs/terraform-aws-github-runner/issues/2511)) ([204acf1](philips-labs/terraform-aws-github-runner@204acf1))
* Security improvements, add option to disable userdata logging ([9a9e2ee](philips-labs/terraform-aws-github-runner@9a9e2ee)), closes [#1019](https://github.com/philips-labs/terraform-aws-github-runner/issues/1019) [#899](https://github.com/philips-labs/terraform-aws-github-runner/issues/899) [#1080](https://github.com/philips-labs/terraform-aws-github-runner/issues/1080) [#748](https://github.com/philips-labs/terraform-aws-github-runner/issues/748) [#1112](https://github.com/philips-labs/terraform-aws-github-runner/issues/1112) [#903](https://github.com/philips-labs/terraform-aws-github-runner/issues/903) [#1082](https://github.com/philips-labs/terraform-aws-github-runner/issues/1082) [#1133](https://github.com/philips-labs/terraform-aws-github-runner/issues/1133) [#2](philips-labs/terraform-aws-github-runner#2) [#1204](https://github.com/philips-labs/terraform-aws-github-runner/issues/1204) [#1219](https://github.com/philips-labs/terraform-aws-github-runner/issues/1219) [#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202) [#1202](https://github.com/philips-labs/terraform-aws-github-runner/issues/1202) [#1135](https://github.com/philips-labs/terraform-aws-github-runner/issues/1135) [#1164](https://github.com/philips-labs/terraform-aws-github-runner/issues/1164) [#1154](https://github.com/philips-labs/terraform-aws-github-runner/issues/1154) [#1207](https://github.com/philips-labs/terraform-aws-github-runner/issues/1207) [#1203](https://github.com/philips-labs/terraform-aws-github-runner/issues/1203) [#1247](https://github.com/philips-labs/terraform-aws-github-runner/issues/1247) [#1222](https://github.com/philips-labs/terraform-aws-github-runner/issues/1222) [#1244](https://github.com/philips-labs/terraform-aws-github-runner/issues/1244) [#1223](https://github.com/philips-labs/terraform-aws-github-runner/issues/1223) [#1254](https://github.com/philips-labs/terraform-aws-github-runner/issues/1254) [#1286](https://github.com/philips-labs/terraform-aws-github-runner/issues/1286) [#1287](https://github.com/philips-labs/terraform-aws-github-runner/issues/1287) [#1278](https://github.com/philips-labs/terraform-aws-github-runner/issues/1278) [#1354](https://github.com/philips-labs/terraform-aws-github-runner/issues/1354) [#1357](https://github.com/philips-labs/terraform-aws-github-runner/issues/1357) [#1356](https://github.com/philips-labs/terraform-aws-github-runner/issues/1356) [#1228](https://github.com/philips-labs/terraform-aws-github-runner/issues/1228) [#1324](https://github.com/philips-labs/terraform-aws-github-runner/issues/1324) [#1358](https://github.com/philips-labs/terraform-aws-github-runner/issues/1358) [#1377](https://github.com/philips-labs/terraform-aws-github-runner/issues/1377) [#1368](https://github.com/philips-labs/terraform-aws-github-runner/issues/1368) [#1381](https://github.com/philips-labs/terraform-aws-github-runner/issues/1381) [#1415](https://github.com/philips-labs/terraform-aws-github-runner/issues/1415) [#1416](https://github.com/philips-labs/terraform-aws-github-runner/issues/1416) [#1423](https://github.com/philips-labs/terraform-aws-github-runner/issues/1423) [#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399) [#1401](https://github.com/philips-labs/terraform-aws-github-runner/issues/1401) [#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444) [#1480](https://github.com/philips-labs/terraform-aws-github-runner/issues/1480) [#1478](https://github.com/philips-labs/terraform-aws-github-runner/issues/1478) [#1479](https://github.com/philips-labs/terraform-aws-github-runner/issues/1479) [#1476](https://github.com/philips-labs/terraform-aws-github-runner/issues/1476) [#1537](https://github.com/philips-labs/terraform-aws-github-runner/issues/1537) [#1538](https://github.com/philips-labs/terraform-aws-github-runner/issues/1538) [#1541](https://github.com/philips-labs/terraform-aws-github-runner/issues/1541) [#1542](https://github.com/philips-labs/terraform-aws-github-runner/issues/1542) [#1399](https://github.com/philips-labs/terraform-aws-github-runner/issues/1399) [#1444](https://github.com/philips-labs/terraform-aws-github-runner/issues/1444) [#1572](https://github.com/philips-labs/terraform-aws-github-runner/issues/1572) [#1556](https://github.com/philips-labs/terraform-aws-github-runner/issues/1556) [#1561](https://github.com/philips-labs/terraform-aws-github-runner/issues/1561) [#1525](https://github.com/philips-labs/terraform-aws-github-runner/issues/1525) [#1591](https://github.com/philips-labs/terraform-aws-github-runner/issues/1591) [#1577](https://github.com/philips-labs/terraform-aws-github-runner/issues/1577) [#1621](https://github.com/philips-labs/terraform-aws-github-runner/issues/1621) [#1611](https://github.com/philips-labs/terraform-aws-github-runner/issues/1611) [#1615](https://github.com/philips-labs/terraform-aws-github-runner/issues/1615) [#1624](https://github.com/philips-labs/terraform-aws-github-runner/issues/1624) [#1628](https://github.com/philips-labs/terraform-aws-github-runner/issues/1628) [#1647](https://github.com/philips-labs/terraform-aws-github-runner/issues/1647) [#1644](https://github.com/philips-labs/terraform-aws-github-runner/issues/1644) [#1673](https://github.com/philips-labs/terraform-aws-github-runner/issues/1673) [#1676](https://github.com/philips-labs/terraform-aws-github-runner/issues/1676) [#1716](https://github.com/philips-labs/terraform-aws-github-runner/issues/1716) [#1741](https://github.com/philips-labs/terraform-aws-github-runner/issues/1741) [#1738](https://github.com/philips-labs/terraform-aws-github-runner/issues/1738) [#1745](https://github.com/philips-labs/terraform-aws-github-runner/issues/1745) [#1718](https://github.com/philips-labs/terraform-aws-github-runner/issues/1718) [#1791](https://github.com/philips-labs/terraform-aws-github-runner/issues/1791) [github.com/philips-labs/terraform-aws-github-runner/pull/1816#issuecomment-1060650668](https://github.com/philips-labs/github.com/philips-labs/terraform-aws-github-runner/pull/1816/issues/issuecomment-1060650668) [#1816](https://github.com/philips-labs/terraform-aws-github-runner/issues/1816) [#1833](https://github.com/philips-labs/terraform-aws-github-runner/issues/1833) [#1798](https://github.com/philips-labs/terraform-aws-github-runner/issues/1798) [#1815](https://github.com/philips-labs/terraform-aws-github-runner/issues/1815) [#1838](https://github.com/philips-labs/terraform-aws-github-runner/issues/1838) [#1797](https://github.com/philips-labs/terraform-aws-github-runner/issues/1797) [#1839](https://github.com/philips-labs/terraform-aws-github-runner/issues/1839) [#1812](https://github.com/philips-labs/terraform-aws-github-runner/issues/1812) [#1854](https://github.com/philips-labs/terraform-aws-github-runner/issues/1854) [#1855](https://github.com/philips-labs/terraform-aws-github-runner/issues/1855) [#1845](https://github.com/philips-labs/terraform-aws-github-runner/issues/1845) [#1832](https://github.com/philips-labs/terraform-aws-github-runner/issues/1832) [#1859](https://github.com/philips-labs/terraform-aws-github-runner/issues/1859) [#1937](https://github.com/philips-labs/terraform-aws-github-runner/issues/1937) [#1969](https://github.com/philips-labs/terraform-aws-github-runner/issues/1969) [#1970](https://github.com/philips-labs/terraform-aws-github-runner/issues/1970) [#1954](https://github.com/philips-labs/terraform-aws-github-runner/issues/1954) [#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019) [#1739](https://github.com/philips-labs/terraform-aws-github-runner/issues/1739) [#2019](https://github.com/philips-labs/terraform-aws-github-runner/issues/2019) [#2024](https://github.com/philips-labs/terraform-aws-github-runner/issues/2024) [#2051](https://github.com/philips-labs/terraform-aws-github-runner/issues/2051) [#1858](https://github.com/philips-labs/terraform-aws-github-runner/issues/1858) [#2085](https://github.com/philips-labs/terraform-aws-github-runner/issues/2085) [#2121](https://github.com/philips-labs/terraform-aws-github-runner/issues/2121) [#2073](https://github.com/philips-labs/terraform-aws-github-runner/issues/2073) [#2146](https://github.com/philips-labs/terraform-aws-github-runner/issues/2146) [#2145](https://github.com/philips-labs/terraform-aws-github-runner/issues/2145) [#2147](https://github.com/philips-labs/terraform-aws-github-runner/issues/2147) [#2122](https://github.com/philips-labs/terraform-aws-github-runner/issues/2122) [#2123](https://github.com/philips-labs/terraform-aws-github-runner/issues/2123) [#2181](https://github.com/philips-labs/terraform-aws-github-runner/issues/2181) [#2207](https://github.com/philips-labs/terraform-aws-github-runner/issues/2207) [#2102](https://github.com/philips-labs/terraform-aws-github-runner/issues/2102) [#2214](https://github.com/philips-labs/terraform-aws-github-runner/issues/2214) [#2052](https://github.com/philips-labs/terraform-aws-github-runner/issues/2052) [#2074](https://github.com/philips-labs/terraform-aws-github-runner/issues/2074) [#2233](https://github.com/philips-labs/terraform-aws-github-runner/issues/2233) [#2288](https://github.com/philips-labs/terraform-aws-github-runner/issues/2288) [#2302](https://github.com/philips-labs/terraform-aws-github-runner/issues/2302) [#2291](https://github.com/philips-labs/terraform-aws-github-runner/issues/2291) [#2209](https://github.com/philips-labs/terraform-aws-github-runner/issues/2209) [#2315](https://github.com/philips-labs/terraform-aws-github-runner/issues/2315) [#2314](https://github.com/philips-labs/terraform-aws-github-runner/issues/2314) [#2103](https://github.com/philips-labs/terraform-aws-github-runner/issues/2103) [#2345](https://github.com/philips-labs/terraform-aws-github-runner/issues/2345) [#2387](https://github.com/philips-labs/terraform-aws-github-runner/issues/2387) [#2371](https://github.com/philips-labs/terraform-aws-github-runner/issues/2371) [#2431](https://github.com/philips-labs/terraform-aws-github-runner/issues/2431) [#2369](https://github.com/philips-labs/terraform-aws-github-runner/issues/2369) [#2346](https://github.com/philips-labs/terraform-aws-github-runner/issues/2346) [#2325](https://github.com/philips-labs/terraform-aws-github-runner/issues/2325) [#2434](https://github.com/philips-labs/terraform-aws-github-runner/issues/2434) [#2455](https://github.com/philips-labs/terraform-aws-github-runner/issues/2455)

### Bug Fixes

* Remove resource group from module ([#2512](https://github.com/philips-labs/terraform-aws-github-runner/issues/2512)) ([2628352](philips-labs/terraform-aws-github-runner@2628352))

forest-releaser bot mentioned this pull request

chore(main): release 4.0.0 #3233

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet