Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Aug 25, 2025

Pull request events identify members as "contributors", so the workflows are not auto-triggered. But there are some contributors who are not members, so workflows would fail on forks.

In this change, we switch the condition for PR events to check for whether the PR was created from a branch in the repo or from a fork.

Note that only users with write access to the repo can create branches.

Fixes #175

cc @leehagoodjames @sethvargo

@jerop jerop requested review from a team as code owners August 25, 2025 12:28
@gemini-cli
Copy link

gemini-cli bot commented Aug 25, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@jerop jerop force-pushed the workflows/auto-pr-review branch from a314a92 to e9f9fb9 Compare August 25, 2025 12:29
@gemini-cli
Copy link

gemini-cli bot commented Aug 25, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval, but I suggest we document this inline for future reference.

@jerop jerop force-pushed the workflows/auto-pr-review branch 2 times, most recently from 42aebf8 to f7c66ad Compare August 25, 2025 12:48
Pull request events identify members as "contributors", so the
workflows are not auto-triggered. But there are some contributors
who are not members, so workflows would fail on forks.

In this change, we switch the condition for PR events to check for
whether the PR was created from a branch in the repo or from a fork.

Note that only users with write access to the repo can create branches.
@jerop jerop force-pushed the workflows/auto-pr-review branch from f7c66ad to 64a6642 Compare August 25, 2025 12:49
@jerop
Copy link
Contributor Author

jerop commented Aug 25, 2025

@sethvargo added inline documentation, thanks!

@jerop jerop merged commit ef32d44 into main Aug 25, 2025
9 checks passed
@jerop jerop deleted the workflows/auto-pr-review branch August 25, 2025 12:54
google-github-actions-bot added a commit that referenced this pull request Aug 26, 2025
## What's Changed
* fix(output): separate the stdout and stderr logs by @sethvargo in
#186
* fix: correct step numbering in setup_workload_identity.sh by
@jasmeetsb in
#188
* Try and address TOCTOU issues in gemini-cli.yml by @sethvargo in
#187
* chore: bump `actions/checkout` GitHub Actions by @Marukome0743 in
#193
* docs: add gitignore recommendations across all workflows by @jerop in
#198
* chore: bump `actions/create-github-app-token` from 2.0.6 to 2.1.1 by
@Marukome0743 in
#200
* bug(output): do not print output by default by @sethvargo in
#202
* Add GOOGLE_API_KEY variable by @vivekkairi in
#201
* Stream live output if (and only if) debug mode is enabled by
@sethvargo in
#207
* bug(debug): use `vars` (not `env`) when enabling debug mode by
@sethvargo in
#211
* feat: Add GEMINI_MODEL support by @vivekkairi in
#214
* feat(actions): use the dispatcher pattern to separate concerns by
@sethvargo in
#212
* bug(ci): set id-token permissions by @sethvargo in
#223
* chore: add a debugger by @sethvargo in
#226
* Add release notes generation example in awesome list by @jerop in
#225
* feat(invoke): update invoke prompt to better separate execution flow
by @sethvargo in
#227
* chore(ci): refactor scheduled triage workflow by @sethvargo in
#232
* Fix triage workflow by @sethvargo in
#233
* Auto trigger PR reviews when they are from branches in repo by @jerop
in #234
* rename workflow from `gemini-issue-scheduled-triage` to
`gemini-scheduled-triage` by @jerop in
#238
* feat: rename triage workflows by @jerop in
#240
* feat: rename gemini-cli to gemini-invoke by @jerop in
#239
* rename PR review workflow to be consistent with the rest by @jerop in
#241
* feat(workflows): refactor examples/workflows to use dispatch pattern
by @jerop in
#242
* feat: pin example workflows to v0 by @jerop in
#246
* add google_api_key input in gemini-triage workflows by @jerop in
#243
* feat: add best practices guide by @jerop in
#245

## New Contributors
* @vivekkairi made their first contribution in
#201

**Full Changelog**:
v0.1.11...v0.1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

PR Reviews are not happening automatically

3 participants