Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: organize workflow inputs alphabetically and add missing parameters #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

chore: organize workflow inputs alphabetically and add missing parameters #288

merged 1 commit into from
Sep 17, 2025

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Sep 17, 2025 •
edited
Loading

  • Reorganize all workflow inputs in alphabetical order for better readability
  • Move settings and prompt parameters to the end of input lists
  • Add missing parameters to all workflows (reorganizing them made it easier to notice missing inputs)
  • Apply changes to both examples/workflows and .github/workflows directories
  • Ensure consistent parameter ordering across all Gemini workflows

Fixes #280

@jerop jerop requested review from a team as code owners September 17, 2025 14:23
@gemini-cli
Copy link

gemini-cli bot commented Sep 17, 2025

🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@jerop jerop enabled auto-merge (squash) September 17, 2025 14:24
gemini-cli[bot]
gemini-cli bot reviewed Sep 17, 2025
View reviewed changes
Copy link

@gemini-cli gemini-cli bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request improves the readability and consistency of the GitHub workflow files by organizing the inputs in alphabetical order and adding missing optional parameters. The changes are well-structured and applied consistently across all relevant files. This is a good maintenance improvement.

🔍 General Feedback

  • The changes are consistent and well-organized.
  • This is a good example of keeping the codebase clean and maintainable.

@jerop jerop changed the title chore: organize workflow inputs alphabetically and add missing optional parameters chore: organize workflow inputs alphabetically and add optional parameters Sep 17, 2025
@jerop jerop changed the title chore: organize workflow inputs alphabetically and add optional parameters chore: organize workflow inputs alphabetically and add missing parameters Sep 17, 2025
leehagoodjames
leehagoodjames reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@leehagoodjames leehagoodjames left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerop can we use ./scripts/generate-examples.sh?

It appears the examples have drifted slightly (in whitespace) from the actual workflows - and using that script can help keep them more in sync.

@jerop
chore: organize workflow inputs alphabetically and add missing option…
3d4228d 
…al parameters

- Reorganize all workflow inputs in alphabetical order for better readability
- Move settings and prompt parameters to the end of input lists
- Add missing optional parameters (gemini_debug, gemini_model, google_api_key) to all workflows (reorganizing them made it easier to notice missing inputs)
- Apply changes to both examples/workflows and .github/workflows directories
- Ensure consistent parameter ordering across all Gemini workflows
@jerop jerop force-pushed the chore/organize-workflow-inputs branch from 3a46d1f to 3d4228d Compare September 17, 2025 15:44
@jerop
Copy link
Contributor Author

jerop commented Sep 17, 2025

./scripts/generate-examples.sh

ran this script and fixed the whitespace issue

leehagoodjames
leehagoodjames approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@leehagoodjames leehagoodjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jerop jerop merged commit 04eed5c into main Sep 17, 2025
37 checks passed
@jerop jerop deleted the chore/organize-workflow-inputs branch September 17, 2025 15:53
@google-github-actions-bot google-github-actions-bot mentioned this pull request Oct 9, 2025
Merged
google-github-actions-bot added a commit that referenced this pull request Oct 9, 2025
@google-github-actions-bot
Release: v0.1.13 (#349)
c110ef5 
## What's Changed
* chore: script to generate examples by @leehagoodjames in
#244
* chore: update readme to state user must copy gemini-dispatch.yml by
@leehagoodjames in
#249
* Relax node requirement and bump actions-utils by @sethvargo in
#253
* feat: support /fix slash command and workflow by @leehagoodjames in
#190
* feat(docs): improve manual setup instructions for workflows by @jerop
in #263
* feat: improve action input descriptions by @jerop in
#264
* fix: enforce COMMENT event type for submit_pending_pull_request_review
by @jerop in
#271
* docs: add fork support documentation for PR review workflow by @jerop
in #268
* feat(action): add support for preview and nightly versions by @jerop
in #281
* feat(workflows): add gemini_cli_version to all workflows by @jerop in
#279
* feat: migrate to new Gemini CLI configuration format by @jerop in
#284
* feat: clean up temp fix for empty API key by @jerop in
#285
* Sort inputs alphabetically in action.yml by @jerop in
#286
* chore: organize workflow inputs alphabetically and add missing
parameters by @jerop in
#288
* feat: add auth input validation by @jerop in
#289
* fix(action): correct quoting in workflow expressions by @jerop in
#293
* fix(validation): improve validation error messages by @jerop in
#297
* fix(validate-inputs): surface errors in logs, annotation, and step
summary by @jerop in
#299
* feat(validate-inputs): downgrade validation failures to warnings by
@jerop in
#300
* fix(validate-inputs): use env-based bash shebang for portability by
@jerop in
#303
* feat: simplify input validation logic by @jerop in
#304
* fix(action): correct input validation script behavior by @jerop in
#309
* feat: add command substitution security warning by @jerop in
#306
* fix(triage): correct duplicate step numbering in workflow by @aladh in
#331
* feat: Optionally install extensions by @CallumHYoung in
#329
* docs(extensions): add documentation for extensions by @jerop in
#340
* chore(workflows): Apply formatting and fix example prompt by @jerop in
#339
* refactor(workflows): improve prompts to use env vars directly by
@jerop in
#342
* fix(review): Remove --source argument to match CLI 8.0 release by
@CallumHYoung in
#347

## New Contributors
* @aladh made their first contribution in
#331
* @CallumHYoung made their first contribution in
#329

**Full Changelog**:
v0.1.12...v0.1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gemini-cli gemini-cli[bot] gemini-cli[bot] left review comments

@leehagoodjames leehagoodjames leehagoodjames approved these changes

@R2wenD2 R2wenD2 Awaiting requested review from R2wenD2 R2wenD2 is a code owner automatically assigned from google-github-actions/maintainers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

@umairidris umairidris Awaiting requested review from umairidris umairidris is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

@galz10 galz10 Awaiting requested review from galz10 galz10 is a code owner automatically assigned from google-github-actions/run-gemini-cli-maintainers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sort the inputs in workflows

3 participants

@jerop @leehagoodjames