NameError: name 'serviceName' is not defined #130
Comments
|
@tmatsuo, what do you make of this? |
tmatsuo
pushed a commit
to tmatsuo/google-api-python-client
that referenced
this issue
Sep 4, 2015
tmatsuo
pushed a commit
to tmatsuo/google-api-python-client
that referenced
this issue
Sep 4, 2015
tmatsuo
pushed a commit
to tmatsuo/google-api-python-client
that referenced
this issue
Sep 4, 2015
|
@ilius Now the fix is in. Thanks for the report!
I kinda agree, but it's messy because the intention of the new code is automagically setting up the cache for you. I'm open to any suggestions to improve the code though. Thanks again :) |
|
Your welcome :) |
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this issue
Apr 1, 2019
Add functools.wraps() to util.positional().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
File "oauth2client/oauth2client/util.py", line 142, in positional_wrapper
return wrapped(_args, *_kwargs)
File "google-api-python-client/googleapiclient/discovery.py", line 193, in build
content = _retrieve_discovery_doc(requested_url, http, cache_discovery, cache)
File "googleapiclient/discovery.py", line 236, in _retrieve_discovery_doc
raise UnknownApiNameOrVersion("name: %s version: %s" % (serviceName,
NameError: name 'serviceName' is not defined
The same for
versiontoo, not passed to this functionOther http errors are also not handled.
I suggest you move out the codes inside function
_retrieve_discovery_doc, and remove this function because it's only used once.The code is messy
The text was updated successfully, but these errors were encountered: