Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed a NameError on exception, added a unit test. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2015
Merged

Fixed a NameError on exception, added a unit test. #131

merged 1 commit into from
Sep 4, 2015

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Sep 4, 2015

Fixes #130

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2015
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 4, 2015

@nathanielmanistaatgoogle

Sorry about not adding unit test for the exception clause.

nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Sep 4, 2015
View reviewed changes
googleapiclient/discovery.py
content = _retrieve_discovery_doc(requested_url, http, cache_discovery,
cache)
except HttpError as e:
if e.resp.status == 404:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@nathanielmanistaatgoogle
Copy link
Contributor

Thanks for the fix; just the one nitpick comment.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 4, 2015

@nathanielmanistaatgoogle Thanks for the comment, PTAL

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 4, 2015

@nathanielmanistaatgoogle PTAL

nathanielmanistaatgoogle added a commit that referenced this pull request Sep 4, 2015
@nathanielmanistaatgoogle
Merge pull request #131 from tmatsuo/discovery-cache
075a05a 
Fixed a NameError on exception; added a unit test.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 075a05a into googleapis:master Sep 4, 2015
@nathanielmanistaatgoogle
Copy link
Contributor

Thanks!

@tmatsuo tmatsuo deleted the discovery-cache branch September 12, 2015 00:52
akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
@nathanielmanistaatgoogle
Merge pull request googleapis#131 from craigcitro/sdk_fix
b29c1bc 
Be more permissive about GAE SDK versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmatsuo @nathanielmanistaatgoogle @googlebot