Fix incompatibility with oauth2client v2.0.0 #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's also important to specify the requirements version to prevent this happen in the future. |
|
Thanks for the fixes! Please squash commits (there's no need for project history to reflect how you drafted the change) and make sure your commit log message conforms to the commit log message guidelines. |
The v2.0.0 release moved a few modules to a subpackage of oauth2client called contrib. Among these was the locked_file module necessary for credential storage. Sample code for Django, App Engine and Service Accounts needed updates as well.
8ee6992 to
2122d3c
Compare
|
Thanks for the tips! |
sadovnychyi
referenced
this pull request
in sadovnychyi/google-api-python-client
Feb 18, 2016
To prevent breaking changes when one of dependencies is updated with major changes. This depends on google/google-api-python-client/googleapis#179 where oauth2client 2.0 issues are fixed.
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Feb 18, 2016
Fix incompatibility with oauth2client v2.0.0.
akrherz
pushed a commit
to akrherz/google-api-python-client
that referenced
this pull request
Apr 1, 2019
Simplify OpenSSL checks in crypt.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few modules moved to a contrib subpackage of oauth2client and sample code needed updating