Adding flexibility to how run_unit_tests determines what to run. #2475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
commented
Sep 30, 2016
.travis.yml
Outdated
| - (cd speech && tox -e py34) | ||
| - python2.7 scripts/run_unit_tests.py | ||
| - python3.4 scripts/run_unit_tests.py | ||
| - python3.5 scripts/run_unit_tests.py |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ffa44ab to
3ddcbf6
Compare
- Upgrading the `get_tox_env()` helper to support the `TOXENV` env. var. and the current system Python - Ditching tox on Travis for py27, py34 and isolated-cover, this is because those tox environments just farm out the work to tox environments for each subpackage, so it isn't worth waiting for the extra tox env. setup time - Changing back from --tox-env-dir to --tox-env flag in run_unit_tests.py script - Adding py27,py34,py35 back to the `tox` env. list - Letting tox -e py27, etc. allow the current Python to determine their tox env. value
Also - Adding instruction to `CONTRIBUTING` about how to run a subset of tests for packages of your choosing - Moving the "Adding Features" section to the top of the `CONTRIBUTING` doc - Making tiny edits to `CONTRIBUTING` doc, e.g. using a "repo" hyperlink for the repository and updating the link to the `tox` docs
3ddcbf6 to
7e4f576
Compare
Contributor
Author
|
@tseaver @daspecster PTAL |
Contributor
|
Could we rebase this since #2473 was merged? |
Contributor
Author
It's been rebased 😉 |
This was referenced Oct 3, 2016
daspecster
approved these changes
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_tox_env()helper to support theTOXENVenv. var. and the current system Pythontoxon Travis forpy27,py34andisolated-cover, this is because thosetoxenvironments just farm out the work totoxenvironments for each sub-package, so it isn't worth waiting for the extratoxenv. setup time--tox-env-dirto--tox-envflag inrun_unit_tests.pyscript (it could always go back but isn't needed. Also could use theVIRTUAL_ENVenv. var. set by theactivatescript from thevirtualenvtool)py27,py34,py35back to thetoxenv. listtox -e py27, etc. allow the current Python to determine theirtoxenv. valuerun_unit_testsfrom the command lineCONTRIBUTINGdoc changes (see 2nd commit)NOTE: Has #2473 as diffbase.