-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Release datastore 1.7.0 #5683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release datastore 1.7.0 #5683
Conversation
datastore/CHANGELOG.md
Outdated
|
||
### Internal / Testing Changes | ||
|
||
- Add Test runs for Python 3.7 and remove 3.4 (#5295) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Not in this PR, no. Maybe for the next release.
…On Wed, Jul 25, 2018 at 10:05 AM Tres Seaver ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In datastore/CHANGELOG.md
<#5683 (comment)>
:
> @@ -4,6 +4,25 @@
[1]: https://pypi.org/project/google-cloud-datastore/#history
+## 1.7.0
+
+### Implementation Changes
+
+- Do not pass 'offset' once the query iterator has a cursor (#5503)
+
+### Documentation
+
+- minor fix to datastore example (#5452)
+- Add example showing explicit unicode for text values in entities. (#5263)
+
+### Internal / Testing Changes
+
+- Add Test runs for Python 3.7 and remove 3.4 (#5295)
Should we remove the classifier in setup.py as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUcwjN_epPRZwa7SdjJC7EcmC0-S-Oks5uKKVSgaJpZM4VdFBS>
.
|
CI failure due to subsequent merges to |
@theacodes I'm not sure how the process works with merging this kind of PR and generating the appropriate tag. |
@tseaver https://github.com/GoogleCloudPlatform/releasetool if you wanna give it a shot, you just need to run |
0fc3aa0
to
f6b6021
Compare
I couldn't make that work: no PR showed up in the list, and when I manually typed the PR, it crapped out:
So, I tagged |
Did you also create a release?
…On Thu, Jul 26, 2018 at 11:22 AM Tres Seaver ***@***.***> wrote:
@theacodes <https://github.com/theacodes>
you just need to run releasetool tag once this is merged.
I couldn't make that work: no PR showed up in the list, and when I
manually typed the PR, it crapped out:
> Please pick one of the following PRs:
Which one do you want to tag and release?: 5683
Traceback (most recent call last):
File "../releasetool/venv/bin/releasetool", line 11, in <module>
load_entry_point('gcp-releasetool', 'console_scripts', 'releasetool')()
File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 722, in __call__
return self.main(*args, **kwargs)
File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/main.py", line 54, in tag
return releasetool.commands.tag.python.tag()
File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/commands/tag/python.py", line 160, in tag
determine_release_pr(ctx)
File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/commands/tag/python.py", line 65, in determine_release_pr
ctx.release_pr = pulls[pull_idx-1]
IndexError: list index out of range
So, I tagged datastore-1.7.0 and pushed it manually.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc_5YfP5wZLxeRJ422kmtRfWIjJy_ks5uKgjqgaJpZM4VdFBS>
.
|
This pull request was generated using releasetool.
Closes #5680.