Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

[DO_NOT_MERGE]chore: downstream check for all libraries in single job #621

Closed
wants to merge 24 commits into from
Closed

[DO_NOT_MERGE]chore: downstream check for all libraries in single job #621

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
887b80d
chore: run both rounds in a single script
Neenu1995 Nov 8, 2021
a5b7873
chore: make script executable
Neenu1995 Nov 8, 2021
d6819ad
typo
Neenu1995 Nov 8, 2021
21ab7ed
chore: add exception for bigtable
Neenu1995 Nov 8, 2021
403eee2
chore: typo
Neenu1995 Nov 8, 2021
49e44ff
chore: remove pubsub and BQstorage for testing
Neenu1995 Nov 8, 2021
9060073
chore: only run checks if labelled
Neenu1995 Dec 29, 2021
df852b3
chore: generalise script
Neenu1995 Jan 19, 2022
e917ce7
chore: fix typo
Neenu1995 Jan 19, 2022
8784681
chore: add retry option
Neenu1995 Jan 19, 2022
791677b
chore: change timeout
Neenu1995 Jan 19, 2022
8e104ae
chore: running retry test
Neenu1995 Jan 19, 2022
600272a
chore: add retry option
Neenu1995 Jan 20, 2022
73a2040
chore: remove random test
Neenu1995 Jan 20, 2022
911bee6
chore: formating
Neenu1995 Jan 20, 2022
c2f52ba
chore: display .m2 content
Neenu1995 Jan 25, 2022
79d91cb
chore: remove retry
Neenu1995 Jan 25, 2022
f137d9d
chore: revome random import
Neenu1995 Jan 25, 2022
e012d8b
chore: add license
Neenu1995 Jan 25, 2022
dad1aec
chore: add comments and flags
Neenu1995 Jan 25, 2022
5420177
chore: add maven export
Neenu1995 Jan 25, 2022
07764b0
chore: remove retry with maven
Neenu1995 Jan 25, 2022
ddbd965
chore: run test on client libraries
Neenu1995 Jan 25, 2022
ddb68ac
chore: fix typo
Neenu1995 Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: formating
  • Loading branch information
@Neenu1995
Neenu1995 committed Jan 20, 2022
commit 911bee628ff3a78e7ef77e3a60448cb10544b0dc
12 changes: 4 additions & 8 deletions .kokoro/downstream-client-library-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ set -eo pipefail
# Display commands being run.
set -x


CORE_LIBRARY_ARTIFACT=$1
CLIENT_LIBRARY=$2
## Get the directory of the build script
Expand All @@ -28,10 +27,8 @@ cd ${scriptDir}/..
# Make java core library artifacts available for 'mvn validate' at the bottom
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V -q
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding -ntp -fae


# Read the current version of this java core library in the POM. Example version: '0.116.1-alpha-SNAPSHOT'
CORE_VERSION_POM=pom.xml
# Namespace (xmlns) prevents xmllint from specifying tag names in XPath
CORE_VERSION=`sed -e 's/xmlns=".*"//' ${CORE_VERSION_POM} | xmllint --xpath '/project/version/text()' -`
CORE_VERSION=`sed -e 's/xmlns=".*"//' pom.xml | xmllint --xpath '/project/version/text()' -`

if [ -z "${CORE_VERSION}" ]; then
echo "Version is not found in ${CORE_VERSION_POM}"
Expand All @@ -46,7 +43,7 @@ git clone "https://github.com/googleapis/java-shared-dependencies.git" --depth=1
pushd java-shared-dependencies/first-party-dependencies

# replace version
xmllint --shell <(cat pom.xml) << EOF
xmllint --shell pom.xml << EOF
setns x=http://maven.apache.org/POM/4.0.0
cd .//x:artifactId[text()="${CORE_LIBRARY_ARTIFACT}"]
cd ../x:version
Expand All @@ -58,9 +55,8 @@ EOF
cd ..
mvn -Denforcer.skip=true clean install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding -ntp -fae


SHARED_DEPS_VERSION_POM=pom.xml
# Namespace (xmlns) prevents xmllint from specifying tag names in XPath
SHARED_DEPS_VERSION=`sed -e 's/xmlns=".*"//' ${SHARED_DEPS_VERSION_POM} | xmllint --xpath '/project/version/text()' -`
SHARED_DEPS_VERSION=`sed -e 's/xmlns=".*"//' pom.xml | xmllint --xpath '/project/version/text()' -`

if [ -z "${SHARED_DEPS_VERSION}" ]; then
echo "Version is not found in ${SHARED_DEPS_VERSION_POM}"
Expand All @@ -78,7 +74,7 @@ if [[ $CLIENT_LIBRARY == "bigtable" ]]; then
fi

# replace version
xmllint --shell <(cat pom.xml) << EOF
xmllint --shell pom.xml << EOF
setns x=http://maven.apache.org/POM/4.0.0
cd .//x:artifactId[text()="google-cloud-shared-dependencies"]
cd ../x:version
Expand Down