Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jun 24, 2025

This PR is currently blocked until the Enterprise dbs support standard RunQuery calls, since the tests heavily rely on running both queries for comparison


This PR extends pipeline expressions to allow converting from a Query to a Pipeline expression. All necessary stages and expressions have been added

Most of the changes in the PR is relatively boiler plate. pipeline_stages and pipeline_expressions have some new classes. But the main change to review is base_query.pipeline(), which implements the conversion from query to pipeline format

Note:
The intention of this PR was to have all system test queries add verify_query, to compare results between pipelines and standard RunQuery calls. But RunQuery is currently not available in enterprise dbs. Instead, the PR adds the configuration to run those tests locally, with a TODO (and related #1065) to add it to the CI in the future

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/python-firestore API. labels Jun 24, 2025
Base automatically changed from pipeline_queries_3_stable_stages to pipeline_queries_approved July 16, 2025 17:57
@daniel-sanche daniel-sanche changed the title [DRAFT] feat: query to pipeline conversion feat: query to pipeline conversion Jul 16, 2025
@daniel-sanche daniel-sanche marked this pull request as ready for review July 16, 2025 22:30
@daniel-sanche daniel-sanche requested review from a team as code owners July 16, 2025 22:30
@daniel-sanche daniel-sanche changed the title feat: query to pipeline conversion [DRAFT] feat: query to pipeline conversion Jul 17, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants