-
Notifications
You must be signed in to change notification settings - Fork 82
[DRAFT] feat: query to pipeline conversion #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniel-sanche
wants to merge
202
commits into
pipeline_queries_approved
Choose a base branch
from
pipeline_queries_3_5_query_conversion
base: pipeline_queries_approved
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DRAFT] feat: query to pipeline conversion #1071
daniel-sanche
wants to merge
202
commits into
pipeline_queries_approved
from
pipeline_queries_3_5_query_conversion
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_3_5_query_conversion
…_3_5_query_conversion
Base automatically changed from
pipeline_queries_3_stable_stages
to
pipeline_queries_approved
July 16, 2025 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: firestore
Issues related to the googleapis/python-firestore API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently blocked until the Enterprise dbs support standard RunQuery calls, since the tests heavily rely on running both queries for comparison
This PR extends pipeline expressions to allow converting from a Query to a Pipeline expression. All necessary stages and expressions have been added
Most of the changes in the PR is relatively boiler plate. pipeline_stages and pipeline_expressions have some new classes. But the main change to review is base_query.pipeline(), which implements the conversion from query to pipeline format
Note:
The intention of this PR was to have all system test queries add verify_query, to compare results between pipelines and standard RunQuery calls. But RunQuery is currently not available in enterprise dbs. Instead, the PR adds the configuration to run those tests locally, with a TODO (and related #1065) to add it to the CI in the future