fix: mockserver_tests #938
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Thank you for maintaining this library. Please let me try to contribute. (Sorry for creating noisy 2 PRs)
I have realized "mockserver_tests" failed with current main branch with Github Actions.
I assuming this fails came from outside library change and just fix Test code to pass it.
please correct me if this require actual code need to be changed
Here is update summary
This pull request updates several unit tests in
test_basics.py
to account for the introduction of a newCreateSessionRequest
in the request sequence when interacting with the mock Spanner service. The main change is that each tested operation now expects an additional session creation request, and the assertions have been updated accordingly. This ensures that the tests accurately reflect the current behavior of the service.Test assertion updates for session creation:
CreateSessionRequest
to the imports and updated all relevant test assertions to expect an additional request in the sequence (BatchCreateSessionsRequest
,CreateSessionRequest
, thenExecuteSqlRequest
orCommitRequest
).verify_select1
,test_django_select_singer
, andtest_django_select_singer_using_other_db
to expect three requests, with the second being aCreateSessionRequest
instead of directly anExecuteSqlRequest
. [1] [2] [3]test_insert_singer
and theLocalSinger
model test to expect four requests (includingCreateSessionRequest
), and adjusted parameter count checks to reference the correct request index. [1] [2]