Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mitsuo0114
Copy link
Contributor

@mitsuo0114 mitsuo0114 commented Sep 6, 2025

Hello, Thank you for maintaining this library. Please let me try to contribute. (Sorry for creating noisy 2 PRs)
I have realized "mockserver_tests" failed with current main branch with Github Actions.

I assuming this fails came from outside library change and just fix Test code to pass it.
please correct me if this require actual code need to be changed

Here is update summary


This pull request updates several unit tests in test_basics.py to account for the introduction of a new CreateSessionRequest in the request sequence when interacting with the mock Spanner service. The main change is that each tested operation now expects an additional session creation request, and the assertions have been updated accordingly. This ensures that the tests accurately reflect the current behavior of the service.

Test assertion updates for session creation:

  • Added CreateSessionRequest to the imports and updated all relevant test assertions to expect an additional request in the sequence (BatchCreateSessionsRequest, CreateSessionRequest, then ExecuteSqlRequest or CommitRequest).
  • Modified assertions in verify_select1, test_django_select_singer, and test_django_select_singer_using_other_db to expect three requests, with the second being a CreateSessionRequest instead of directly an ExecuteSqlRequest. [1] [2] [3]
  • Updated test_insert_singer and the LocalSinger model test to expect four requests (including CreateSessionRequest), and adjusted parameter count checks to reference the correct request index. [1] [2]

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Sep 6, 2025
@mitsuo0114 mitsuo0114 marked this pull request as ready for review September 6, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant