Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[v2] dns: implement shared zones list #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented May 22, 2025

This is a manual backport of the #3390

@kayrus kayrus requested a review from EmilienM May 22, 2025 14:50
@github-actions github-actions bot added edit:dns This PR updates dns code v2 This PR targets v2 semver:major Breaking change labels May 22, 2025
@coveralls
Copy link

Coverage Status

coverage: 63.663% (-0.02%) from 63.679%
when pulling 29194cf on kayrus:list-zone-share-v2
into af02ce6 on gophercloud:v2.

@kayrus
Copy link
Contributor Author

kayrus commented May 28, 2025

@EmilienM @mandre @pierreprinetti @stephenfin kindly ping

Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts are in tests and are due to commit eed41cd being absent, which we probably don't want to backport due to its size.

PS: @kayrus it would be helpful if this information ☝️ was included in the commit message since I assume you had to figure that out yourself to do the backport and it'd save me the effort of figuring it out again. For example, see 2435700. Just my 2c

@stephenfin
Copy link
Contributor

stephenfin commented May 28, 2025

Also, the designate dalmatian failure is expected until they merge https://review.opendev.org/c/openstack/designate/+/950569/3 (and revert https://review.opendev.org/c/openstack/designate/+/949094)

@kayrus
Copy link
Contributor Author

kayrus commented May 29, 2025

@stephenfin thanks for the references.
@EmilienM I'll wait for your approval, since you have concerns about the major semver tag.

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandre mandre merged commit 6b87370 into gophercloud:v2 Jun 2, 2025
15 of 16 checks passed
@kayrus kayrus deleted the list-zone-share-v2 branch June 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:dns This PR updates dns code semver:major Breaking change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants