-
Notifications
You must be signed in to change notification settings - Fork 569
Add Go 1.18 support #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Skimming through the draft release notes, I note the following:
|
I've created a new go1.18-wip branch to do the work in. Here's an easy recipe to start working on 1.18 support:
|
My go1.18-wip branch now has complete Go 1.18 compatibility with the exception of generics, which brings us to the question of our approach to the release. I plan to start working on generics at some point soon, but this is a large and complicated feature and will take a while to get right. The big question is whether to block GopherJS 1.18 release until that work is completed or not. The main argument in favor of delaying the release is that generics is arguably the most important feature in Go 1.18 and it would be highly confusing to release GopherJS 1.18 without it; also generics seem like too big a feature to release in a patch-release of 1.18.x. At the same time there are multiple arguments against postponing the release:
When we discussed this with @flimzy a while ago we arrived at a middle ground of making several GopherJS 1.18beta releases until generics have landed, and then making a "stable" release. That way we can signal that we are not quite compatible with Go 1.18, and avoid releasing generics as a patch release. I think we could go for that, but approach of Go 1.19 may be changing that equation a bit. We have to start on 1.19 support pretty much immediately after 1.18 is merged. We could release GopherJS 1.18 without generics and include them into GopherJS 1.19 release, which should happen soon-ish anyway. I'm inviting the community to share their preferences, if any :) |
I would prefer merging the go1.18 support without generics & then add generics later. I'm not using Generics yet very much and I think anyone who is would catch the build failure right away. |
I've merged the |
GopherJS 1.18.0-beta1 is officially released. We plan to make a stable release once generics support is completed. If you are interested in Go 1.19 support, you can follow #1140. |
Go 1.18 beta 1 is out. That means it's time to start working toward adding support to GopherJS.
Re-enableMoved to GopherJS generics supportΒ #1013.encoding/xml
tests once generics are supported.syscall/js
: RemoveWrapper
interface.The text was updated successfully, but these errors were encountered: