Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document supported GOOS values in README (FreeBSD is not supported). #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cryptix opened this issue Mar 7, 2018 · 4 comments
Closed

Document supported GOOS values in README (FreeBSD is not supported). #770

cryptix opened this issue Mar 7, 2018 · 4 comments
Labels
documentation

Comments

@cryptix
Copy link

cryptix commented Mar 7, 2018

I tried to integrate a gopherjs build step into our jenkins CI, which is running on FreeBSD.

The same command runs fine in my dev environment under Linux.

[staging ~]$ gopherjs build -o viewer.js proj/viewer
../../local/go/src/vendor/golang_org/x/net/route/address.go:25:42: undeclared name: sysAF_LINK
../../local/go/src/vendor/golang_org/x/net/route/address.go:42:9: undeclared name: sysAF_LINK
../../local/go/src/vendor/golang_org/x/net/route/address.go:64:35: undeclared name: sysAF_LINK
../../local/go/src/vendor/golang_org/x/net/route/address.go:124:43: undeclared name: sysAF_INET
../../local/go/src/vendor/golang_org/x/net/route/address.go:127:9: undeclared name: sizeofSockaddrInet
../../local/go/src/vendor/golang_org/x/net/route/address.go:127:37: undeclared name: sizeofSockaddrInet
../../local/go/src/vendor/golang_org/x/net/route/address.go:136:9: undeclared name: sysAF_INET
../../local/go/src/vendor/golang_org/x/net/route/address.go:148:43: undeclared name: sysAF_INET6
../../local/go/src/vendor/golang_org/x/net/route/address.go:151:9: undeclared name: sizeofSockaddrInet6
../../local/go/src/vendor/golang_org/x/net/route/address.go:151:38: undeclared name: sizeofSockaddrInet6
../../local/go/src/vendor/golang_org/x/net/route/address.go:151:38: too many errors

Would like to supply more info but I'm not even sure where these paths come from..
I'm using Go 1.10 and GopherJS 1.10-2.
@dmitshur
Copy link
Member

dmitshur commented Mar 8, 2018 •
edited
Loading

This looks very similar to, and there is a lot of useful and relevant information in issue #511. I'm not sure that we did anything to resolve it.

Edit: We did have PR #513, but it was closed with the alternative solution of relying on GOOS=linux being chosen.

Edit 2: The commit message of perkeep/perkeep@749d512 summarizes the situation nicely.

@cryptix
Copy link
Author

cryptix commented Mar 8, 2018

Ah! Thank you for digging this up!

I tried to search for closed issues but was too tired, I guess.

I‘m closing this since it is clearly a duplicate.

@cryptix cryptix closed this as completed Mar 8, 2018
@dmitshur
Copy link
Member

dmitshur commented Mar 8, 2018

Agree it’s a duplicate, but let’s document FreeBSD as unsupported in the README, so we don’t have to rely on people searching through closed issues and PRs to figure that out. We can use this issue to track that.

@dmitshur dmitshur reopened this Mar 8, 2018
@dmitshur dmitshur changed the title FreeBSD: undeclared name Document supported GOOS values in README (FreeBSD is not supported). Mar 8, 2018
@cryptix
Copy link
Author

cryptix commented Mar 8, 2018

Yes, sure!

ps: I also successfully checked the workaround.

@dmitshur dmitshur self-assigned this Mar 16, 2018
dmitshur added a commit that referenced this issue Mar 16, 2018
@dmitshur
Document supported GOOS values.
6d9f40b 
Add instructions for what people should do when building with GopherJS
on unsupported platforms. Code generation works completely fine, but
syscalls (e.g., for gopherjs run) will only work on supported platforms.

Previously, this information was only in issues, people's heads, commit
messages, etc. It should be documented in README to provide clarity.

Rename "OS X" to "macOS", the current name of that operating system.
Rearrange sections to place more relevant information first. Mention
Linux before macOS consistently. Linux is placed first because it's open
source and more freely available than the proprietary macOS, so it's
easier to recommend it as an alternative.

Resolves #770.
Updates #776.
Updates #688.
@dmitshur dmitshur mentioned this issue Mar 16, 2018
Merged
@dmitshur dmitshur removed their assignment Mar 16, 2018
dmitshur added a commit that referenced this issue Mar 17, 2018
@dmitshur
README: Document supported GOOS values. (#777)
82b3220 
Add instructions for what people should do when building with GopherJS
on unsupported platforms. Code generation works completely fine, but
syscalls (e.g., for gopherjs run) will only work on supported platforms.

Previously, this information was only in issues, people's heads, commit
messages, etc. It should be documented in README to provide clarity.

Rename "OS X" to "macOS", the current name of that operating system.
Rearrange sections to place more relevant information first. Mention
Linux before macOS consistently. Linux is placed first because it's open
source and more freely available than the proprietary macOS, so it's
easier to recommend it as an alternative.

Resolves #770.
Updates #776.
Updates #688.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cryptix @dmitshur