Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[go1.20] update go1.20 with master #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Conversation

grantnelson-wf
Copy link
Collaborator

It's that time again; want all those beautiful master changes in go1.20. Bumping go1.20 with master.

This is part of #1270

nevkontakte and others added 5 commits May 25, 2024 22:22
For each package-level entity we emit one or more Decl struct, which
contains all JS code fragments and metadata required to produce the
final executable script.

For each decl type (imports, vars, functions and types) I created a
separate function that contains the logic responsible for its creation
(and some auxiliary functions). The main objective is to keep the
Compile() function very high-level and clearly reflecting various
compilation stages we go through.

I tried to add comments to make the code more accessible for future
contributors (and future self...), although there are still some aspects
I don't fully grasp.

Ideally, we would have tests for all these new functions, but that's way
more work than I'm able to take on right now.

(based on commit 146735d)
compiler: break functions related to Decls out of Compile().
The logic is already very complicated and breaking it up into more
manageable methods will improve readability.

 - Broke out nestedFunctionContext() and translateStandaloneFunction()
 - Removed the need to return function param names from
   translateFunctionBody()

(based on commit 2e9a5ce)
Move function translation code into a separate file.
@nevkontakte nevkontakte merged commit 938fba2 into gopherjs:go1.20 Jul 3, 2024
4 of 8 checks passed
@grantnelson-wf grantnelson-wf deleted the bumpMaster branch July 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants