fixes blocking when using function literals #956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be. A new field is used in info.go. It's name kept short to keep gofmt from readjusting surrounding lines. It's not the most descriptive name as it stands. A short test case that demonstrates the problem can be found in issue gopherjs#955. Fixes gopherjs#955.
|
Hi @FrankReh, we are finally working through the backlog of issues and pull requests. Sorry it took so long! Can you please rebase this PR on the latest version of master? Also it would be nice to add your test case |
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Apr 19, 2022
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be. This change makes blocking status propagate through any number of intermediate literal function calls. This is a rebase of gopherjs#956. Fixes gopherjs#955. Co-authored-by: FrankReh
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Apr 19, 2022
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be. This change makes blocking status propagate through any number of intermediate literal function calls. This is a rebase of gopherjs#956. Fixes gopherjs#955. Co-authored-by: Frank Rehwinkel <[email protected]>
flimzy
pushed a commit
that referenced
this pull request
Apr 19, 2022
When a function literal is used that calls another function and that other function has yet to be analyzed, the call site for the function literal is not retained, so it's not processed later, so the function that was calling the function literal is not made blocking itself, when it should be. This change makes blocking status propagate through any number of intermediate literal function calls. This is a rebase of #956. Fixes #955. Co-authored-by: Frank Rehwinkel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function literal is used that calls another function and
that other function has yet to be analyzed, the call site for
the function literal is not retained, so it's not processed later,
so the function that was calling the function literal is not made
blocking itself, when it should be.
A new field is used in info.go. It's name kept short to keep gofmt
from readjusting surrounding lines. It's not the most descriptive name
as it stands.
A short test case that demonstrates the problem can be found in
issue #955.
Fixes #955.