Avoid double implicit type conversion on deferred built-in arguments. #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because certain built-in function may not be translated into callable expressions, GopherJS wraps them into a proxy lambda function when necessary. Prior to this change it was incorrectly inferring argument types for this proxy function, which led to a possible double implicit type conversion and a runtime error in the generated code. With this change, the types are assigned in accordance with what the deferred function expects, and therefore no double conversion will happen. This change allows TesSliceNoCycle in `encoding/json` to pass under Go 1.16.
flimzy
approved these changes
Mar 18, 2021
This was referenced Nov 21, 2021
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Nov 21, 2021
Built-ins and `js.Object` methods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda. gopherjs#998 has fixed a similar issue for the `defer` keyword, and this change generalizes the same fix for the `go` keyword. Fixes gopherjs#547.
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Nov 21, 2021
Built-ins and `js.Object` methods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda. gopherjs#998 has fixed a similar issue for the `defer` keyword, and this change generalizes the same fix for the `go` keyword. Fixes gopherjs#547.
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Nov 21, 2021
Built-ins and `js.Object` methods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda. gopherjs#998 has fixed a similar issue for the `defer` keyword, and this change generalizes the same fix for the `go` keyword. Fixes gopherjs#547.
nevkontakte
added a commit
to nevkontakte/gopherjs
that referenced
this pull request
Dec 19, 2021
Built-ins and `js.Object` methods are represented by JS expressions that may not be straightforward function calls, or reference functions defined in the prelude. In such cases, the callable expression must be wrapped in a lambda. gopherjs#998 has fixed a similar issue for the `defer` keyword, and this change generalizes the same fix for the `go` keyword. Fixes gopherjs#547.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because certain built-in function may not be translated into callable
expressions, GopherJS wraps them into a proxy lambda function when
necessary. Prior to this change it was incorrectly inferring argument
types for this proxy function, which led to a possible double implicit
type conversion and a runtime error in the generated code.
With this change, the types are assigned in accordance with what the
deferred function expects, and therefore no double conversion will
happen.
This change allows TesSliceNoCycle in
encoding/jsonto pass underGo 1.16.
Updates #989.