Disallow requesting alignment limits that are ≥ 2**32 #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This text used to allow requesting alignment limits like 2**32 or 2**53. This didn't do anything useful, but it adds implementation complexity, because, per this spec, alignment limits are 32-bit integers. In order to implement that you would need a special case to handle the casting of the GPUSize64 (from the record<>) to a uint32_t internally.
7 tasks
|
Previews, as seen when this build job started (6a855bf): |
|
Yes we are in support of this as well. 2**32 - 1 should be the maximum value. |
|
Looks good to Mozilla. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This text used to allow requesting alignment limits like 232 or 253. This didn't do anything useful, but it adds implementation complexity, because, per this spec, alignment limits are 32-bit integers. In order to implement that you would need a special case to handle the casting of the
GPUSize64(from therecord<DOMString, GPUSize64>) to auint32_tinternally.Test: gpuweb/cts#3132
Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5002999