Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disallow requesting alignment limits that are ≥ 2**32 #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Disallow requesting alignment limits that are ≥ 2**32 #4358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Disallow requiring alignment limits >= 2**32 
This text used to allow requesting alignment limits like 2**32 or 2**53.
This didn't do anything useful, but it adds implementation complexity,
because, per this spec, alignment limits are 32-bit integers. In order
to implement that you would need a special case to handle the casting of
the GPUSize64 (from the record<>) to a uint32_t internally.
  • Loading branch information
@kainino0x
kainino0x committed Nov 2, 2023
commit 6a855bf8bd4d0e33762c1a0db6a5dbfba0f363f7
2 changes: 1 addition & 1 deletion spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,7 +2668,7 @@ interface GPUAdapter {
- |value| must be no [=limit/better=] than the value of that limit in
|adapter|.{{adapter/[[limits]]}}.
- If the limit's [=limit class|class=] is [=limit class/alignment=],
|value| must be a power of 2.
|value| must be a power of 2 less than 2<sup>32</sup>.
</div>

Then issue the following steps on <var data-timeline=content>contentTimeline</var>
Expand Down