Allow index < limits.maxBindGroups in getBindGroupLayout()
#5042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch relaxes the check on the parameter `index` in `getBindGroupLayout()` by allowing `index < limits.maxBindGroups` instead of only limiting `index` must be less than the array size of the bind group layouts used in the creation of the pipeline.
|
Previews, as seen when this build job started (f8a2c1c): |
|
LGTM. @jimblandy @mwyrzykowski PTAL as well! This is a small improvement found while implementing the "empty BGLs are equivalent to null" in Dawn. Basically any BGL in the pipeline is fine to query, even once past what's specified in the pipeline layout, because it's as if they are null/empty. |
kainino0x
reviewed
Jan 18, 2025
|
The build errors are not related to this PR. @kainino0x PTAL, thanks! |
|
@Jiawei-Shao I created #5046 to address WGSL part of the build issues, thank you for pointing out the presence |
kainino0x
approved these changes
Jan 23, 2025
GPU Web WG 2025-01-22 Atlantic-time
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch relaxes the check on the parameter
indexingetBindGroupLayout()by allowingindex < limits.maxBindGroupsinstead of only limitingindexmust be less than the array size of the bind group layouts used in the creation of the pipeline.