Merge arrayLayerCount into size.depth #613
Conversation
|
|
||
| * {{GPUTextureViewDescriptor/arrayLayerCount}}: | ||
| If 0, defaults to |texture|.{{GPUTextureDescriptor/arrayLayerCount}} − {{GPUTextureViewDescriptor/baseArrayLayer}}. | ||
| If 0, defaults to |texture|.{{GPUTextureDescriptor/size}}.[=Extent3D/depth=] − {{GPUTextureViewDescriptor/baseArrayLayer}}. |
There was a problem hiding this comment.
This can be confusing for the cube arrays. We can't say that the view array count defaults to the depth in this case.
There was a problem hiding this comment.
Resolved in meeting, this is an orthogonal issue and we'll open a new issue.
|
|
||
| - {{GPUQueue/copyImageBitmapToTexture()}}: | ||
| - For now, `copySize.z` must be `1`. | ||
| - For now, {{GPUQueue/copyImageBitmapToTexture(source, destination, copySize)/copySize}}.[=Extent3D/depth=] must be `1`. |
|
@kainino0x how does one create a 1D array texture now? Do they pass the layer count as |
|
Good question. We don't have 1d-array texture views in the spec right now so I'm not sure whether it's supposed to be possible in core, but I can't think of a strong argument to choose either over the other. |
|
I wonder if we have documented the reason somewhere why 1D array views are not a good idea. |
577: Remove array layer count from texture descriptor r=grovesNL a=kvark Matches gpuweb/gpuweb#613 Co-authored-by: Dzmitry Malyshau <[email protected]>
|
I think it was an accident. I suspect the texture view dimension list was copied from Dawn where we had never tried to implement it (still haven't). See #90 |
|
Filed #699 |
For the version where we take sequence instead of dictionary, it should be This wouldn't be a problem if we only accepted the sequence (as I have advocated) ;) |
Similar to what was done for GPUTextureDescriptor in gpuweb#613, I just missed it.
* Merge GPUTextureCopyView.arrayLayer into .origin.z Similar to what was done for GPUTextureDescriptor in #613, I just missed it. * update more text as needed * address comments
* Merge GPUTextureCopyView.arrayLayer into .origin.z Similar to what was done for GPUTextureDescriptor in gpuweb#613, I just missed it. * update more text as needed * address comments
* Merge GPUTextureCopyView.arrayLayer into .origin.z Similar to what was done for GPUTextureDescriptor in gpuweb#613, I just missed it. * update more text as needed * address comments
* Merge GPUTextureCopyView.arrayLayer into .origin.z Similar to what was done for GPUTextureDescriptor in gpuweb#613, I just missed it. * update more text as needed * address comments
💥 Error: write EPROTO 140049978214272:error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version:../deps/openssl/openssl/ssl/s23_clnt.c:772:
💥 ###
PR Preview failed to build. (Last tried on Mar 14, 2020, 3:05 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.