Fix #36601: Set proper file permissions for results-generic.bin on POSIX systems#36708
Merged
Conversation
Contributor
Author
|
@octylFractal I've implemented the fix based on your suggestion in #36601 — replaced the Could you take a look when you get a chance? Thanks! |
Member
|
Thank you for your proposed contribution! This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices. |
Contributor
Author
|
Thanks for the review @octylFractal ! All feedback addressed
|
octylFractal
approved these changes
Feb 18, 2026
tresat
approved these changes
Feb 18, 2026
Files.createTempFile() creates files with owner-only permissions (600) on POSIX systems. When moved to the final results-generic.bin location, these restrictive permissions were preserved, unlike other output files. Remove the temporary file pattern and write directly to the target file via Files.newOutputStream(), which respects the system umask. Signed-off-by: CHANHAN <[email protected]>
Verify that all files in the binary test results directory have group-read and others-read permissions on POSIX systems. Signed-off-by: CHANHAN <[email protected]>
Reorder 'binary test result files have correct permissions' test to appear before private utility methods in AbstractTestTaskIntegrationTest, following Spock test class conventions. Signed-off-by: CHANHAN <[email protected]>
Replace listFiles() with Files.walk() to validate permissions for all files including subdirectories. Remove NioFiles import alias and use java.nio.file.Files fully-qualified name for better readability outside IDE. Signed-off-by: CHANHAN <[email protected]>
Replace Files.createTempFile() with a fixed-name in-progress file written via Files.newOutputStream() to respect system umask, while preserving the temporary file + move pattern to avoid leaving incomplete results on write failure. Signed-off-by: CHANHAN <[email protected]>
Updated the temporary results file path logic to use Path.resolveSibling() instead of getParent().resolve() based on code review feedback. Signed-off-by: CHANHAN <[email protected]>
Member
|
Thank you for your contribution! |
Contributor
Author
|
Hi @octylFractal, it looks like this PR was removed from the merge queue due to some failed TeamCity checks earlier. However, all 17 checks are passing now and there are no conflicts with the base branch. Could you please re-add this to the merge queue when you have a chance? I believe the previous failure was just a transient CI issue rather than something caused by the changes in this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36601
Since Gradle 9.3.0,
results-generic.binis created with owner-only permissions (-rw-------) on POSIX systems, while other files in the same directory likeoutput-events.bincorrectly respect the system umask.The cause was
SerializableTestResultStore.WriterusingFiles.createTempFile()+Files.move().createTempFile()defaults to 600 permissions on POSIX, andmove()preserves them.This PR replaces that pattern with a direct
Files.newOutputStream()write, which naturally follows the system umask.An integration test was added in
AbstractTestTaskIntegrationTestto verify that all binary test result files have group-read and others-read permissions on POSIX systems.