Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #36601: Set proper file permissions for results-generic.bin on POSIX systems #36708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cobexer merged 6 commits into from
Feb 20, 2026
Merged

Fix #36601: Set proper file permissions for results-generic.bin on POSIX systems #36708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f76441
Fix #36601: Replace createTempFile+move with direct file write
chanani Feb 12, 2026
42cbfe9
Add integration test for binary test result file permissions
chanani Feb 12, 2026
74fad2c
refactor: move permission test above private methods for consistency
chanani Feb 18, 2026
02c3543
refactor: use Files.walk() and fully-qualified names in permission test
chanani Feb 18, 2026
cbd2fd6
fix: use fixed-name in-progress file instead of createTempFile
chanani Feb 18, 2026
908c1a4
refactor : path resolution using resolveSibling()
chanani Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...esting-jvm/src/integTest/groovy/org/gradle/testing/AbstractTestTaskIntegrationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.gradle.testing.fixture.AbstractTestingMultiVersionIntegrationTest
import spock.lang.Issue

import java.time.Duration
import java.nio.file.attribute.PosixFilePermission

import static org.hamcrest.Matchers.greaterThanOrEqualTo

Expand Down Expand Up @@ -397,6 +398,25 @@ abstract class AbstractTestTaskIntegrationTest extends AbstractTestingMultiVersi
"after" | afterClassAnnotation
}

@Requires(UnitTestPreconditions.FilePermissions)
def "binary test result files have correct permissions"() {
given:
file('src/test/java/MyTest.java') << standaloneTestClass

when:
succeeds 'test'

then:
def binaryDir = file("build/test-results/test/binary")
java.nio.file.Files.walk(binaryDir.toPath())
.filter { java.nio.file.Files.isRegularFile(it) }
.each { path ->
def perms = java.nio.file.Files.getPosixFilePermissions(path)
assert perms.contains(PosixFilePermission.OTHERS_READ)
assert perms.contains(PosixFilePermission.GROUP_READ)
}
}

private String buildRequestingNewerJavaVersion() {
"""
java {
Expand Down
10 changes: 5 additions & 5 deletions ...g/gradle/api/internal/tasks/testing/results/serializable/SerializableTestResultStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ private static int depth(TestDescriptorInternal descriptor) {
private final Set<Object> flatteningIds;
private final List<TestDescriptorInternal> extraFlattenedDescriptors;
private final List<TestResult> extraFlattenedResults;
private final Path serializedResultsFile;
private final int diskSkipLevels;
private final Path temporaryResultsFile;
/**
* Encoder storing the serialized test results.
*/
private final Path serializedResultsFile;
private final Path temporaryResultsFile;
private final KryoBackedEncoder resultsEncoder;
private final TestOutputWriter outputWriter;
private long nextId = 1;
Expand All @@ -111,14 +111,14 @@ private static int depth(TestDescriptorInternal descriptor) {
private final Multimap<TestDescriptorInternal, TestMetadataEvent> metadatas = LinkedHashMultimap.create();

private Writer(Path serializedResultsFile, Path outputEventsFile, int diskSkipLevels) throws IOException {
this.serializedResultsFile = serializedResultsFile;
this.diskSkipLevels = diskSkipLevels;
this.serializedResultsFile = serializedResultsFile;
this.temporaryResultsFile = serializedResultsFile.resolveSibling("in-progress-results-generic.bin");
// Use constants to avoid allocating empty collections if flattening is not enabled
flatteningIds = isDiskSkipEnabled() ? new HashSet<>() : Collections.emptySet();
extraFlattenedDescriptors = isDiskSkipEnabled() ? new ArrayList<>() : Collections.emptyList();
extraFlattenedResults = isDiskSkipEnabled() ? new ArrayList<>() : Collections.emptyList();
Files.createDirectories(serializedResultsFile.getParent());
temporaryResultsFile = Files.createTempFile(serializedResultsFile.getParent(), "in-progress-results-generic", ".bin");
resultsEncoder = new KryoBackedEncoder(Files.newOutputStream(temporaryResultsFile));
Serializer<TestOutputEvent> testOutputEventSerializer = TestEventSerializer.create().build(TestOutputEvent.class);
try {
Expand Down Expand Up @@ -296,7 +296,7 @@ public void close() throws IOException {
} finally {
CompositeStoppable.stoppable(resultsEncoder, outputWriter).stop();
}
// Move the temporary results file to the final location, if successful
// Move the completed in-progress file to the final location
Files.move(temporaryResultsFile, serializedResultsFile, StandardCopyOption.REPLACE_EXISTING);
}
}
Expand Down