Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documentation for new Hive Platform / Components #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 23, 2017

Conversation

Rendili
Copy link
Contributor

@Rendili Rendili commented Oct 9, 2017

New documentation for new Hive platform / components

Pull request in home-assistant (if applicable): home-assistant/core#9804

@fabaff fabaff added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration labels Oct 9, 2017
@fabaff fabaff removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 6, 2017
@Rendili Rendili closed this Nov 10, 2017
@Rendili Rendili reopened this Nov 13, 2017
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rendili, Thank you for submitting a PR. I've found some minor issues. Could you please take a look at those?

---


The 'hive' climate component integrates your Hive thermostat and hot water in to Home Assistant, enabling control of setting the **mode** and setting the **target temperature**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: in to -> into

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

footer: true
logo: hive.png
ha_category: Climate
ha_release: 0.62
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wanna update the version number (in all other files as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck
Thanks for reviewing.
I did not know which version number the code PR for the Hive component / platform would actually be released in, so I put a prediction.

What version would you recommended to put here, I don't anticipate the code being accepted any time soon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah ok, that makes sense I guess. We usually put in the next version (which will be 0.59)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update to 0.59 and hope for the best :)

---


This Hive component is the main component to setup and integrate all supported Hive devices. Once configured with the minimum required details it will detect and add all your Hive devices in to Home Assistant, including support for multizone heating.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double spaces detected: Hive devices. Once, remove one.
Typo: setup -> set up
Typo: in to-> into

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


This Hive component is the main component to setup and integrate all supported Hive devices. Once configured with the minimum required details it will detect and add all your Hive devices in to Home Assistant, including support for multizone heating.

This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com) and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma: Hive website [https://my.hivehome.com](https://my.hivehome.com), and you will

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com) and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant.

To add all your Hive devices in to your Home Assistant installation add the following to your 'configuration.yaml' file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: in to -> into

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


Configuration variables:

- **username** (*Required*): Username from [https://my.hivehome.com](https://my.hivehome.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags to list configuration variables. For more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what needs changing here.
Please could you point me to an existing file which demonstrates this in use and what I am missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See for example this component: https://raw.githubusercontent.com/home-assistant/home-assistant.github.io/next/source/_components/device_tracker.hitron_coda.markdown

The configuration variables are listed using some code and then rendered. In your current version, they are simply markdown (which is the old way we did it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks.

I have updated, but a little unsure of what to do with the option variable scan_interval and any examples needed with and without it, as the configuration tags documentation webpage said only add required variables.

- **scan_interval** (*Optional*): The default update frequency is once every 2 minutes, use this to specify a custom minutes between updates.


To add all your Hive devices in to your Home Assistant installation, specifying the optional **devices** variable add the following to your 'configuration.yaml' file. You can remove each of the options in the **devices** variable for the corresponding Hive device you would like not to be added to Home Assistant:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: in to -> into
This sentence has reading/wording issues. Please review it, try reading it out loud and consider rewording it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the typo
removed the sentence. It would have made more sense had this feature been allowed in the code :)

---


The 'hive' sensor component integrates your Hive sensors in to Home Assistant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: in to -> into

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

---


The 'hive' light component integrates your Hive lights in to Home Assistant, enabling control of various settings, depending on model light.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: in to -> into
Missing determiner: on the model light.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@frenck
Copy link
Member

frenck commented Nov 19, 2017

I have updated, but a little unsure of what to do with the option variable scan_interval and any examples needed with and without it, as the configuration tags documentation webpage said only add required variables.

You only add required variables in the "example" yaml configuration partials. The configuration variables should be all documented of course.

@Rendili
Copy link
Contributor Author

Rendili commented Nov 19, 2017

ok, I think I understand.

Does that document make sense and is it ok now? I documented the option variable in there, but not added to that new configuration sections

@frenck frenck self-assigned this Nov 20, 2017
@Rendili
Copy link
Contributor Author

Rendili commented Nov 21, 2017

@frenck All files updated as suggested

description: Your password from [https://my.hivehome.com](https://my.hivehome.com).
required: true
type: string
{% endconfiguration %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scan_interval is still missing in this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the document on this said not to include optionals?
I can add it if you like of course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that example configurations should be kept minimal. This is not the example we are talking about here. This part is the actual options list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @frenck
Updated.

@frenck frenck removed their assignment Nov 22, 2017

This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com), and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant.

To add your Hive devices into your Home Assistant installation, with an update frequency of every five minutes (the default is every two minutes if the scan_interval variable is not specified) add the following to your 'configuration.yaml' file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the reference to five minutes. The example doesn't include the scan interval option anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

---


The 'hive' sensor component can expose as a sensor the current online status of your Hive Hub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

---


The 'hive' switch component integrates your Hive plugs Home Assistant, enabling control of your devices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "into". "... integrates your Hive plugs into Home Assistant."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@frenck frenck merged commit ee6bb09 into home-assistant:next Nov 23, 2017
@Rendili Rendili deleted the next branch December 9, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants