-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Documentation for new Hive Platform / Components #3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rendili, Thank you for submitting a PR. I've found some minor issues. Could you please take a look at those?
--- | ||
|
||
|
||
The 'hive' climate component integrates your Hive thermostat and hot water in to Home Assistant, enabling control of setting the **mode** and setting the **target temperature**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: in to
-> into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
footer: true | ||
logo: hive.png | ||
ha_category: Climate | ||
ha_release: 0.62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might wanna update the version number (in all other files as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frenck
Thanks for reviewing.
I did not know which version number the code PR for the Hive component / platform would actually be released in, so I put a prediction.
What version would you recommended to put here, I don't anticipate the code being accepted any time soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah ok, that makes sense I guess. We usually put in the next version (which will be 0.59
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update to 0.59 and hope for the best :)
source/_components/hive.markdown
Outdated
--- | ||
|
||
|
||
This Hive component is the main component to setup and integrate all supported Hive devices. Once configured with the minimum required details it will detect and add all your Hive devices in to Home Assistant, including support for multizone heating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double spaces detected: Hive devices. Once
, remove one.
Typo: setup
-> set up
Typo: in to
-> into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
source/_components/hive.markdown
Outdated
|
||
This Hive component is the main component to setup and integrate all supported Hive devices. Once configured with the minimum required details it will detect and add all your Hive devices in to Home Assistant, including support for multizone heating. | ||
|
||
This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com) and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma: Hive website [https://my.hivehome.com](https://my.hivehome.com), and you will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
source/_components/hive.markdown
Outdated
|
||
This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com) and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant. | ||
|
||
To add all your Hive devices in to your Home Assistant installation add the following to your 'configuration.yaml' file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: in to
-> into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
source/_components/hive.markdown
Outdated
|
||
Configuration variables: | ||
|
||
- **username** (*Required*): Username from [https://my.hivehome.com](https://my.hivehome.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the configuration tags to list configuration variables. For more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what needs changing here.
Please could you point me to an existing file which demonstrates this in use and what I am missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See for example this component: https://raw.githubusercontent.com/home-assistant/home-assistant.github.io/next/source/_components/device_tracker.hitron_coda.markdown
The configuration variables are listed using some code and then rendered. In your current version, they are simply markdown (which is the old way we did it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, thanks.
I have updated, but a little unsure of what to do with the option variable scan_interval
and any examples needed with and without it, as the configuration tags documentation webpage said only add required variables.
source/_components/hive.markdown
Outdated
- **scan_interval** (*Optional*): The default update frequency is once every 2 minutes, use this to specify a custom minutes between updates. | ||
|
||
|
||
To add all your Hive devices in to your Home Assistant installation, specifying the optional **devices** variable add the following to your 'configuration.yaml' file. You can remove each of the options in the **devices** variable for the corresponding Hive device you would like not to be added to Home Assistant: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: in to
-> into
This sentence has reading/wording issues. Please review it, try reading it out loud and consider rewording it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the typo
removed the sentence. It would have made more sense had this feature been allowed in the code :)
--- | ||
|
||
|
||
The 'hive' sensor component integrates your Hive sensors in to Home Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: in to
-> into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
--- | ||
|
||
|
||
The 'hive' light component integrates your Hive lights in to Home Assistant, enabling control of various settings, depending on model light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: in to
-> into
Missing determiner: on the model light
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
You only add required variables in the "example" yaml configuration partials. The configuration variables should be all documented of course. |
ok, I think I understand. Does that document make sense and is it ok now? I documented the option variable in there, but not added to that new configuration sections |
@frenck All files updated as suggested |
source/_components/hive.markdown
Outdated
description: Your password from [https://my.hivehome.com](https://my.hivehome.com). | ||
required: true | ||
type: string | ||
{% endconfiguration %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scan_interval
is still missing in this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the document on this said not to include optionals?
I can add it if you like of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states that example configurations should be kept minimal. This is not the example we are talking about here. This part is the actual options list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @frenck
Updated.
source/_components/hive.markdown
Outdated
|
||
This component uses the unofficial API used in the official Hive website [https://my.hivehome.com](https://my.hivehome.com), and you will need to use the same Username and Password you use on the Hive website to configure this Hive component in Home Assistant. | ||
|
||
To add your Hive devices into your Home Assistant installation, with an update frequency of every five minutes (the default is every two minutes if the scan_interval variable is not specified) add the following to your 'configuration.yaml' file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the reference to five minutes. The example doesn't include the scan interval option anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
--- | ||
|
||
|
||
The 'hive' sensor component can expose as a sensor the current online status of your Hive Hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
--- | ||
|
||
|
||
The 'hive' switch component integrates your Hive plugs Home Assistant, enabling control of your devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "into". "... integrates your Hive plugs into Home Assistant."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
New documentation for new Hive platform / components
Pull request in home-assistant (if applicable): home-assistant/core#9804