-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Mention power and energy consumption in docs #36241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request adds two new sensor metrics to the Starlink integration documentation for Home Assistant. The new metrics include "Power," which indicates the last measured power consumption in watts, and "Energy," which reflects the measured energy consumption since the last reboot in kilowatt-hours. These additions enhance the existing documentation without altering any existing functionality or control flow. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Request Starlink integration details
Documentation-->>User: Provide existing metrics
Documentation-->>User: Provide new metrics (Power, Energy)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/_integrations/starlink.markdown (1)
46-46
: Consider clarifying the energy measurement reset behavior.The current description mentions "since reboot", but it might be helpful to clarify if this is a Starlink system reboot or a Home Assistant restart.
Consider this minor enhancement:
-Energy - Measured energy consumption since reboot [kWh] +Energy - Measured energy consumption since last Starlink system reboot [kWh]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/starlink.markdown
(1 hunks)
🔇 Additional comments (1)
source/_integrations/starlink.markdown (1)
45-46
: LGTM! Verifying implementation in core.
The documentation additions for power and energy sensors are well-formatted and consistent with the existing style.
Let's verify these sensors are implemented in the core PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
home-assistant/core#132262 exposes power and energy consumption. This PR mentions that in the docs.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit