-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add eta for nest.set_mode service, add security_state to sensor.nest #5518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
source/_components/nest.markdown
Outdated
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant. | ||
- **eta**: Estimated Arrival Time from now, in `HH:MM` or `HH:MM:SS` format. | ||
- **eta_window**: Optional ETA window, in `HH:MM` or `HH:MM:SS` format. Default is 1 minute. | ||
- **trip_id**: Optional identity for your estimation, useing same `trip_id` to update previous esitmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useing -> using. esitmation -> estimation. Please improve the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar changes
source/_components/nest.markdown
Outdated
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant. | ||
- **eta**: Estimated Arrival Time from now. | ||
- **eta_window**: Optional ETA window. Default is 1 minute. | ||
- **trip_id**: Optional identity for your estimation, using same `trip_id` to update previous estimation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change line to: **trip_id** (*Optional*): Unique ID for the trip. Using an existing trip ID will update that trip's ETA.
source/_components/nest.markdown
Outdated
- **home_mode** (*Required*): `home` or `away` | ||
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant. | ||
- **eta**: Estimated Arrival Time from now. | ||
- **eta_window**: Optional ETA window. Default is 1 minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change line to: **eta_window** (*Optional*): ETA window in minutes. (default: 1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly right, since the param type has been changed to time_period
source/_components/nest.markdown
Outdated
|
||
- **home_mode** (*Required*): `home` or `away` | ||
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant. | ||
- **eta**: Estimated Arrival Time from now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change line to: **eta** (*Optional*): Estimated Time of Arrival (in minutes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly right, since the param type has been changed to time_period
source/_components/nest.markdown
Outdated
can also be set with `eta`, `eta_window`, and `trip_id` parameters. | ||
|
||
- **home_mode** (*Required*): `home` or `away` | ||
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homa Assistant
-> Home Assistant
Description:
Pull request in home-assistant (if applicable): home-assistant/core#14901
Checklist:
current
. New documentation for platforms/components and features should go tonext
.