Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add eta for nest.set_mode service, add security_state to sensor.nest #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2018

Conversation

awarecan
Copy link
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/core#14901

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant.
- **eta**: Estimated Arrival Time from now, in `HH:MM` or `HH:MM:SS` format.
- **eta_window**: Optional ETA window, in `HH:MM` or `HH:MM:SS` format. Default is 1 minute.
- **trip_id**: Optional identity for your estimation, useing same `trip_id` to update previous esitmation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useing -> using. esitmation -> estimation. Please improve the description.

dale3h
dale3h previously requested changes Jun 12, 2018
Copy link
Member

@dale3h dale3h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar changes

- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant.
- **eta**: Estimated Arrival Time from now.
- **eta_window**: Optional ETA window. Default is 1 minute.
- **trip_id**: Optional identity for your estimation, using same `trip_id` to update previous estimation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line to: **trip_id** (*Optional*): Unique ID for the trip. Using an existing trip ID will update that trip's ETA.

- **home_mode** (*Required*): `home` or `away`
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant.
- **eta**: Estimated Arrival Time from now.
- **eta_window**: Optional ETA window. Default is 1 minute.
Copy link
Member

@dale3h dale3h Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line to: **eta_window** (*Optional*): ETA window in minutes. (default: 1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly right, since the param type has been changed to time_period


- **home_mode** (*Required*): `home` or `away`
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant.
- **eta**: Estimated Arrival Time from now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line to: **eta** (*Optional*): Estimated Time of Arrival (in minutes).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly right, since the param type has been changed to time_period

can also be set with `eta`, `eta_window`, and `trip_id` parameters.

- **home_mode** (*Required*): `home` or `away`
- **structure**: Structure(s). Default apply to all structures connected with Homa Assistant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homa Assistant -> Home Assistant

@syssi syssi dismissed dale3h’s stale review June 18, 2018 05:57

Requests addressed

@syssi syssi merged commit ae571bb into home-assistant:next Jun 18, 2018
@awarecan awarecan deleted the patch-2 branch June 26, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants