Add new InitFrequencyAutoRange initialization function #1203
Conversation
| InitDouble(name, defaultVal, minVal, maxVal, step, "", flags, group, ShapeExp(), kUnitCustom); | ||
| auto freqFormatter = [](double val, WDL_String& str, IParam* parent) | ||
| { | ||
| const double onethousand = parent->FromNormalized(parent->ToNormalized(1000.)); |
There was a problem hiding this comment.
This has to be added due to the imprecision of normalization causing an entry of 1000. using a PromptUserInput call as with IVKnobControl. If you don't go through the normalization and back again you an type 1000. and not get 1.00 kHz in the output due to imprecision.
There was a problem hiding this comment.
Thanks for this. I don't want to be picky, but shouldn't there be a solution for the text input '1.2k' as well?
There was a problem hiding this comment.
That would be inconsistent with every existing control but its certainly possible. At the moment all existing controls only accept numbers as inputs and not text. That would be a separate PR. It also has nothing to do with this PR. I was going to also add that cause I also agree it should be supported, but it wouldn't be here, it'd be in the prompt class.
There was a problem hiding this comment.
@TBProAudio here is a partially working implementation of what you asked: #1204 - it needs a bit more work and feedback, but it's definitely heading in the right direction.
If you use it in conjunction with: SetPromptShowsParamLabel(true); it's already quite compelling. But there are a few key missing things that I note on the PR to make it more complete. But it's very doable.
|
Thanks. Yes, works as intended. |
|
There are a few things that need updating, I will try and get to updating this PR this weekend and do another more mature revision. |
With reference to: https://iplug2.discourse.group/t/automatic-hz-khz-change-during-frequency-parameter-changes/984/3 add a new function called: InitFrequencyAutoRange that provides a frequency parameter that automatically changes formatting between Hz and kHz.
Uses the function:
In order to both provide formatting, and also respect either the precomputed precision, or a call to:
SetDisplayPrecisionAll feedback welcome.