Update ITextEntryControl.cpp to support label entry #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial suggestion of how you could go about entering the label as a part of the text entry. For simple examples this already works, but there are some outstanding issues: 1.) It's case sensitive, and probably shouldn't be 2.) You cannot use this with advanced entry, like entries where the label changes type depending on the value 3.) It's limited to a double, it could be extended for all Just throwing this out there to show that it's both possible, and probably not THAT hard. What do people want to see to consider this complete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial suggestion of how you could go about entering the label as a part of the text entry. For simple examples this already works, but there are some outstanding issues:
1.) It's case sensitive, and probably shouldn't be
2.) You cannot use this with advanced entry, like entries where the label changes type depending on the value
3.) It's limited to a double, it could be extended for all
Just throwing this out there to show that it's both possible, and probably not THAT hard.
What do people want to see to consider this complete?
If you use this in conjunction with
SetPromptShowsParamLabel(true);it's already quite compelling: