-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Cleanup / upgrade packages #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup / upgrade packages #1125
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Also add |
There's a bit too much happening in this PR. do you mind separating out the stuff unrelated to package.json dependencies and yarn.lock? |
Specifically the ts-jest changes are controversial and reduce test coverage, so I'd like to discuss those in isolation |
Yep. Sorry, I just can't stop sometimes. |
|
Oh, it was recommended in jest readme so i thought it's ok. |
"marked": "0.3.6", | ||
"microtime": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is actually an optionalDep of benchmark, so I'm adding this back in a follow-up commit
Remove unused / upgrade old dependencies.