Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup / upgrade packages #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 8, 2017
Merged

Cleanup / upgrade packages #1125

merged 8 commits into from
Mar 8, 2017

Conversation

avocadowastaken
Copy link
Contributor

Remove unused / upgrade old dependencies.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@avocadowastaken avocadowastaken changed the title Cleanup package.json Cleanup / upgrade packages Mar 8, 2017
@avocadowastaken
Copy link
Contributor Author

avocadowastaken commented Mar 8, 2017

Also add ts-jest and npm-run-all.
After this updates I will start working on #1111

@leebyron
Copy link
Collaborator

leebyron commented Mar 8, 2017

There's a bit too much happening in this PR. do you mind separating out the stuff unrelated to package.json dependencies and yarn.lock?

@leebyron
Copy link
Collaborator

leebyron commented Mar 8, 2017

Specifically the ts-jest changes are controversial and reduce test coverage, so I'd like to discuss those in isolation

@avocadowastaken
Copy link
Contributor Author

There's a bit too much happening in this PR. do you mind separating out the stuff unrelated to package.json dependencies and yarn.lock?

Yep. Sorry, I just can't stop sometimes.

@avocadowastaken
Copy link
Contributor Author

dist/immutable.min.js changed because of uglify-js update

@avocadowastaken
Copy link
Contributor Author

Specifically the ts-jest changes are controversial and reduce test coverage, so I'd like to discuss those in isolation

Oh, it was recommended in jest readme so i thought it's ok.

@leebyron leebyron merged commit 63649f3 into immutable-js:master Mar 8, 2017
"marked": "0.3.6",
"microtime": "^2.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually an optionalDep of benchmark, so I'm adding this back in a follow-up commit

@avocadowastaken avocadowastaken deleted the cleanup-package-file branch March 9, 2017 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants