IWF-607: Implement Search Attributes store and API #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Overall, looks great to me! I don't see any issues. At the same time, I'm not well versed in Python so I might be missing something. Perhaps once we had the tests we could easily see issues, but I can't say for now |
samuel27m
approved these changes
Mar 13, 2025
ktrops
reviewed
Mar 13, 2025
| types[field.key] = field.value_type | ||
| self._data_attribute_types[wf_type] = types | ||
|
|
||
| def _register_search_attributes(self, wf: ObjectWorkflow): |
Contributor
There was a problem hiding this comment.
I might have missed it, but where/how does this get called.
N-give
reviewed
Mar 13, 2025
| types[field.key] = field.value_type | ||
| self._data_attribute_types[wf_type] = types | ||
|
|
||
| def _register_search_attributes(self, wf: ObjectWorkflow): |
N-give
approved these changes
Mar 14, 2025
ktrops
approved these changes
Mar 14, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set methods and tests will be added in the next MR, which will point to this one, so everything is merged back to the main at once.
Keeping those separate to avoid a huge MR. This is already somewhat big.