Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lwolczynski
Copy link
Contributor

No description provided.

@lwolczynski
Copy link
Contributor Author

I need to troubleshoot why the unit test I added passes locally, but fails here

@samuel27m
Copy link
Member

samuel27m commented Mar 14, 2025

Could it be the Python version we have running locally, versus the one used in the CI pipeline?

============================= test session starts ==============================
platform linux -- Python 3.9.21, pytest-7.4.4, pluggy-1.5.0 -- /home/runner/.cache/pypoetry/virtualenvs/iwf-python-sdk-szf-DUJx-py3.9/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/iwf-python-sdk/iwf-python-sdk
plugins: env-0.8.2, anyio-3.7.1, cov-4.1.0
collecting ... collected 22 items

Locally I have:

❯ python3 -V
Python 3.13.2

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-628 branch from 7e8f565 to 2e56bce Compare March 14, 2025 15:59
@lwolczynski
Copy link
Contributor Author

Could it be the Python version we have running locally, versus the one used in the CI pipeline?

============================= test session starts ==============================
platform linux -- Python 3.9.21, pytest-7.4.4, pluggy-1.5.0 -- /home/runner/.cache/pypoetry/virtualenvs/iwf-python-sdk-szf-DUJx-py3.9/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/iwf-python-sdk/iwf-python-sdk
plugins: env-0.8.2, anyio-3.7.1, cov-4.1.0
collecting ... collected 22 items

Locally I have:

❯ python3 -V
Python 3.13.2

It seems to be flaky since I can't fully control if the search attributes have been set before I query for them. I added a comment on how this could be improved with with wait_for_state_execution_completed, but this is yet to be implemented

@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-628 branch 13 times, most recently from 51a2c52 to 8563220 Compare March 14, 2025 19:26
@lwolczynski lwolczynski marked this pull request as draft March 14, 2025 19:34
@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-628 branch 7 times, most recently from 06e0840 to 3299617 Compare March 14, 2025 20:16
@lwolczynski lwolczynski marked this pull request as ready for review March 14, 2025 20:40
Comment on lines +264 to +265
# if attribute keys is None, will fetch all registered search attributes from the server
if attribute_keys:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @N-give

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for changing that!

Comment on lines +264 to +265
# if attribute keys is None, will fetch all registered search attributes from the server
if attribute_keys:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for changing that!

@lwolczynski lwolczynski changed the base branch from jira/lwolczynski/IWF-607 to main March 17, 2025 16:27
@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-628 branch 2 times, most recently from a7b49a3 to 6cf5d3b Compare March 17, 2025 16:51
@lwolczynski lwolczynski force-pushed the jira/lwolczynski/IWF-628 branch from 6cf5d3b to 4a766e2 Compare March 17, 2025 17:15
@lwolczynski lwolczynski merged commit 622edae into main Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants