-
Notifications
You must be signed in to change notification settings - Fork 3
IWF-628: Add setting search attributes #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I need to troubleshoot why the unit test I added passes locally, but fails here |
|
Could it be the Python version we have running locally, versus the one used in the CI pipeline? Locally I have: |
7e8f565 to
2e56bce
Compare
It seems to be flaky since I can't fully control if the search attributes have been set before I query for them. I added a comment on how this could be improved with |
51a2c52 to
8563220
Compare
06e0840 to
3299617
Compare
| # if attribute keys is None, will fetch all registered search attributes from the server | ||
| if attribute_keys: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @N-give
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for changing that!
| # if attribute keys is None, will fetch all registered search attributes from the server | ||
| if attribute_keys: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for changing that!
a7b49a3 to
6cf5d3b
Compare
6cf5d3b to
4a766e2
Compare
No description provided.