Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: address buffer constructor deprecation#116

Closed
exoego wants to merge 1 commit into
indutny:masterfrom
exoego:buffer-deprecation
Closed

fix: address buffer constructor deprecation#116
exoego wants to merge 1 commit into
indutny:masterfrom
exoego:buffer-deprecation

Conversation

@exoego

@exoego exoego commented Sep 12, 2019

Copy link
Copy Markdown

Closes #102

@exoego exoego mentioned this pull request Sep 12, 2019
Closed
@fanatid fanatid mentioned this pull request Sep 13, 2019
Open
@EthanRBrown

EthanRBrown commented Oct 11, 2019

Copy link
Copy Markdown

I was just about to do this myself. Would love to get this fixed because I'm tired of having my AWS logs cluttered up by deprecation warnings. Is this package abandoned by its maintainers?

@realanmup

realanmup commented Dec 17, 2019

Copy link
Copy Markdown

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
I'll leave this message here. Please merge it asap. Thank you. @indutny

@tabarra tabarra mentioned this pull request Jan 5, 2020
Closed
@panva

panva commented Jan 6, 2020

Copy link
Copy Markdown

I believe this PR is a breaking change for legacy runtimes, it would be appropriate to use this as v6.x breaking, while #103 is suitable for the existing major release line.

@exoego

exoego commented Jan 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

I am fine with #103 which uses safe-buffer module to support legacy Node.js.
Some people may worry about adding such polyfill since it increases complexity of dependency management and increases bundle size.

@indutny

indutny commented Jan 6, 2020

Copy link
Copy Markdown
Owner

Fixed in e186699

@indutny indutny closed this Jan 6, 2020
@exoego exoego deleted the buffer-deprecation branch January 6, 2020 21:13
arweave-kyle added a commit to ArweaveTeam/arweave-js that referenced this pull request Aug 5, 2020
@arweave-kyle
Replaced patched github:arweave-kyle/asn1.js with upstream asn1.js
caa9adc 
No longer need to use the forked version of asn1.js as the upstream package has fixed the deprecated node buffer warnings.

arweave-kyle/asn1.js@d992612

indutny/asn1.js#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@realanmup realanmup realanmup approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buffer constructor runtime deprecation - this package emits a warning on Node 10

5 participants

@exoego @EthanRBrown @realanmup @panva @indutny