Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update bn.js to address Buffer deprecation#197

Closed
exoego wants to merge 3 commits into
indutny:masterfrom
exoego:buffer-deprecation
Closed

Update bn.js to address Buffer deprecation#197
exoego wants to merge 3 commits into
indutny:masterfrom
exoego:buffer-deprecation

Conversation

@exoego

@exoego exoego commented Sep 11, 2019

Copy link
Copy Markdown

Closes #196

@exoego

exoego commented Sep 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Hmm, some tests failed due to this changes in bn.js.
How should these tests be addressed?
Does this indicated an issue in elliptic, or in bn.js ?

EDIT:
I fixed the tests in elliptic 83ff218.

@fanatid

fanatid commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

package-lock.json should not be added. There still no decision how this should be handled. See #191

@exoego

exoego commented Sep 12, 2019

Copy link
Copy Markdown
Author

@fanatid
It seems that Travis complains unless package-lock.json included

@fanatid

fanatid commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

Oh, sorry. package-lock.json in this repo now, that's why Travis show error. On each dependency update package-lock.json should be updated too...

@exoego

exoego commented Sep 12, 2019

Copy link
Copy Markdown
Author

Ok, I will add package-lock.json back.

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates asn1.js 4.10.1 still uses bn.js 4.11.8, which cause another Buffer deprecation.
So I opened a PR indutny/asn1.js#116 to update bn.js in asn1.js too.

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is opened.
browserify/browserify-rsa#12

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserify/browserify-sign#45

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserify/createECDH#13

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserify/diffie-hellman#31

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indutny/miller-rabin#11

exoego
exoego commented Sep 12, 2019
View reviewed changes
Comment thread package-lock.json
},
"dependencies": {
"bn.js": {
"version": "4.11.8",

@exoego exoego Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserify/publicEncrypt#20

@fanatid fanatid mentioned this pull request Sep 13, 2019
Open
@coveralls

coveralls commented Sep 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.006%) to 89.114% when pulling 1894eb9 on exoego:buffer-deprecation into 71e4e8e on indutny:master.

@exoego

exoego commented Sep 29, 2019

Copy link
Copy Markdown
Author

Hello core developers, how should I proceed this and related PRs?

@exoego

exoego commented Jan 20, 2020

Copy link
Copy Markdown
Author

@fanatid
Updated bn.js to 5.1.1 since newer version have been released while waiting review.

@exoego

exoego commented Jan 20, 2020

Copy link
Copy Markdown
Author

Closing as a duplicate, since a maintainer opened a same PR in #210

@exoego exoego closed this Jan 20, 2020
@exoego exoego deleted the buffer-deprecation branch January 20, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecationWarning on Buffer

3 participants

@exoego @fanatid @coveralls