Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Parse column names in a dataframe to avoid breaking the line protocol #584

Merged
merged 12 commits into from
May 8, 2018
Merged

Parse column names in a dataframe to avoid breaking the line protocol #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8a66894
Remove comment as issues have been resolved
dmuiruri Apr 27, 2018
fae177c
Parse column names in a dataframe to handle spaces in tag of field keys
dmuiruri May 3, 2018
fcb02c2
Patch for ERROR: Test failed write points from df with series
dmuiruri May 3, 2018
f0d8968
Merge branch 'master' into master
dmuiruri May 3, 2018
8643984
Patch for flake8 issues(E231, E501)
dmuiruri May 3, 2018
cf683b7
Merge branch 'master' of https://github.com/dmuiruri/influxdb-python
dmuiruri May 3, 2018
009bd35
Test case for spaces in column names
dmuiruri May 4, 2018
deedb06
flake8 issues
dmuiruri May 4, 2018
6ec7eba
flake8 issues: trailing wspace
dmuiruri May 4, 2018
fdb3e7a
Testing if test case would catch a regression
dmuiruri May 5, 2018
1b726f2
Test catches a regressed build
dmuiruri May 5, 2018
61ecb58
Re-run the build
dmuiruri May 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions influxdb/_dataframe_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ def _convert_dataframe_to_lines(self,
raise TypeError('Must be DataFrame with DatetimeIndex or '
'PeriodIndex.')

dataframe = dataframe.rename(
columns={item: _escape_tag(item) for item in dataframe.columns})
# Create a Series of columns for easier indexing
column_series = pd.Series(dataframe.columns)

Expand Down
20 changes: 20 additions & 0 deletions influxdb/tests/dataframe_client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,26 @@ def test_dataframe_write_points_with_whitespace_measurement(self):
cli.write_points(dataframe, 'meas with space')
self.assertEqual(m.last_request.body, expected)

def test_dataframe_write_points_with_whitespace_in_column_names(self):
"""write_points should escape white space in column names."""
now = pd.Timestamp('1970-01-01 00:00+00:00')
dataframe = pd.DataFrame(data=[["1", 1, 1.0], ["2", 2, 2.0]],
index=[now, now + timedelta(hours=1)],
columns=["column one", "column two",
"column three"])
expected = (
b"foo column\\ one=\"1\",column\\ two=1i,column\\ three=1.0 0\n"
b"foo column\\ one=\"2\",column\\ two=2i,column\\ three=2.0 "
b"3600000000000\n"
)
with requests_mock.Mocker() as m:
m.register_uri(requests_mock.POST,
"http://localhost:8086/write",
status_code=204)
cli = DataFrameClient(database='db')
cli.write_points(dataframe, 'foo')
self.assertEqual(m.last_request.body, expected)

def test_write_points_from_dataframe_with_none(self):
"""Test write points from df in TestDataFrameClient object."""
now = pd.Timestamp('1970-01-01 00:00+00:00')
Expand Down