Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Feb 19, 2025

Related: #3168

We'll unpin it when sphinx-autodoc-typehints is fixed.

Signed-off-by: Ihar Hrachyshka [email protected]

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

Related: instructlab#3168

We'll unpin it when sphinx-autodoc-typehints is fixed.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter marked this pull request as ready for review February 19, 2025 01:47
@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 19, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 19, 2025
booxter added a commit to booxter/instructlab that referenced this pull request Feb 19, 2025
Spotted in instructlab#3169 where
docs job was not triggered.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@reidliu41 reidliu41 mentioned this pull request Feb 19, 2025
6 tasks
@booxter
Copy link
Contributor Author

booxter commented Feb 19, 2025

This was folded into #3167 so probably not needed. But we'll need a backport for something like this to release branches. Not sure if it means we should merge this PR anyway first? @cdoern @courtneypacheco advise.

mergify bot added a commit that referenced this pull request Mar 4, 2025
Spotted in #3169 where
docs job was not triggered.

Signed-off-by: Ihar Hrachyshka <[email protected]>











**Checklist:**

- [x] **Commit Message Formatting**: Commit titles and messages follow guidelines in the
  [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary).
- [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release.
- [ ] Documentation has been updated, if necessary.
- [ ] Unit tests have been added, if necessary.
- [ ] Functional tests have been added, if necessary.
- [ ] E2E Workflow tests have been added, if necessary.



Approved-by: ktdreyer

Approved-by: courtneypacheco
@mergify mergify bot merged commit 82b5952 into instructlab:main Mar 27, 2025
6 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants