Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(infra): add cloud-instance list command; ignore shutting-down instances #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Feb 27, 2025
Merged

feat(infra): add cloud-instance list command; ignore shutting-down instances #3198

mergify merged 2 commits into from
Feb 27, 2025

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Feb 27, 2025

Some improvements to the cloud-instance.sh script:

  • feat(infra): add cloud-instance.sh list command
  • feat(infra): ignore shutting-down machines when calculating aws ids

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@booxter booxter requested a review from danmcp February 27, 2025 15:54
@mergify mergify bot added the ci-failure PR has at least one CI failure label Feb 27, 2025
@booxter booxter force-pushed the cloud-infra-list-terminating branch from 922b962 to f757d38 Compare February 27, 2025 15:56
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Feb 27, 2025
danmcp
danmcp reviewed Feb 27, 2025
View reviewed changes
@booxter booxter force-pushed the cloud-infra-list-terminating branch from f757d38 to 3e76e49 Compare February 27, 2025 16:10
@booxter booxter mentioned this pull request Feb 27, 2025
Merged
6 tasks
@booxter booxter requested a review from danmcp February 27, 2025 16:21
@booxter
feat(infra): add cloud-instance.sh list command
6a139b2 
The command lists all matching ids.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter
feat(infra): ignore shutting-down machines when calculating aws ids
e48c5ea 
shutting-down means `The instance is preparing to be terminated.` as
per:

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-lifecycle.html

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter force-pushed the cloud-infra-list-terminating branch from 3e76e49 to e48c5ea Compare February 27, 2025 17:01
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 27, 2025
courtneypacheco
courtneypacheco approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. 👍

@mergify mergify bot merged commit edf0741 into instructlab:main Feb 27, 2025
7 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

+1 more reviewer

@danmcp danmcp danmcp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@booxter @danmcp @courtneypacheco