Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(infra): add -i option for instance id to cloud-instance.sh #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Feb 28, 2025
Merged

feat(infra): add -i option for instance id to cloud-instance.sh #3199

mergify merged 1 commit into from
Feb 28, 2025

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Feb 27, 2025

  • feat(infra): allow to pass instance id with -i in cloud-instance.sh

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@booxter
Copy link
Contributor Author

booxter commented Feb 27, 2025

Will open for review once #3198 is merged and I rebase.

@booxter
feat(infra): allow to pass instance id with -i in cloud-instance.sh
99dd50a 
It was possible to set INSTANCE_ID= envvar; but it was awkward. An
option seems to be better UX to me.

Signed-off-by: Ihar Hrachyshka <[email protected]>
@booxter booxter marked this pull request as ready for review February 27, 2025 22:41
@booxter booxter requested a review from danmcp February 27, 2025 22:41
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 28, 2025
@mergify mergify bot merged commit 9c682f2 into instructlab:main Feb 28, 2025
7 checks passed
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@courtneypacheco courtneypacheco courtneypacheco approved these changes

+1 more reviewer

@danmcp danmcp danmcp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@booxter @danmcp @courtneypacheco