Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danmcp
Copy link
Member

@danmcp danmcp commented Feb 27, 2025

This PR adds new optional config to cloud-instance for letting cloud-instance.sh ec2 launch search for an instance type across multiple subnets for an available instance. Example of the new config:

EC2_SUBNET_VARS=("EC2_SUBNET_ID_1" "EC2_SUBNET_ID_2")
EC2_SUBNET_ID_1=subnet-12345678901234567
EC2_SUBNET_ID_2=subnet-12345678901234568

So if you were looking for a g6e.12xlarge, it would first look in subnet-12345678901234567, if an available instance wasn't found there, it would then look in subnet-12345678901234568. If still no instance was found it would fail.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@danmcp danmcp changed the title Add option to search multiple subnets with launch Add option to search multiple subnets with cloud-instance launch Feb 27, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 27, 2025
Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the interface.

@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Feb 27, 2025
@booxter booxter removed the request for review from ktdreyer February 27, 2025 23:19
@mergify mergify bot merged commit dbb69d5 into instructlab:main Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants